hermes - 💡(How to fix) Fix [a2a_fleet] MEDIUM: relocate tests to tests/plugins/ and cover sync-register + auth-default paths

Official PRs (…)
ON THIS PAGE

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Fix Action

Fix

  • Relocate tests to tests/plugins/a2a_fleet/.
  • Add a test that calls register(ctx) from a plain synchronous context and asserts the server is reachable (today it would not be — see A2A-1).
  • Add tests for auth-default behavior and peer-URL scheme rejection.

Filed from opus-4.8 plugin audit (a2a_fleet).

RAW_BUFFERClick to expand / collapse

Severity: MEDIUM (tests — location + coverage of critical paths)

Evidence

  • Tests colocate at plugins/a2a_fleet/tests/ instead of upstream's tests/plugins/a2a_fleet/ (rubric #7).
  • No test covers A2A-1 (sync-register() no-loop path — test_server_lifecycle.py runs inside pytest-asyncio's loop, masking the real-runtime bug), A2A-2 (auth-default-open), or A2A-6 (URL scheme / SSRF validation).

Fix

  • Relocate tests to tests/plugins/a2a_fleet/.
  • Add a test that calls register(ctx) from a plain synchronous context and asserts the server is reachable (today it would not be — see A2A-1).
  • Add tests for auth-default behavior and peer-URL scheme rejection.

Filed from opus-4.8 plugin audit (a2a_fleet).

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING