hermes - 💡(How to fix) Fix `hermes config set` silently accepts unknown keys, writing them where the runtime never reads [2 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

hermes config set <unknown.key.path> <value> silently accepts arbitrary key paths, writes them to config.yaml, and reports success — but the runtime/gateway never reads them. The user reasonably believes their change took effect, then loses time debugging behavior that hasn't actually changed.

Error Message

At minimum: warn loudly on unknown keys instead of silently writing them into the YAML.

Root Cause

…returns success. hermes config show | grep -A 5 discord is empty, because the value was nested under gateway: rather than platforms:. Restarting the gateway, the Discord restart notification still fires.

Fix Action

Fixed

Code Example

hermes config set gateway.discord.gateway_restart_notification false
RAW_BUFFERClick to expand / collapse

Summary

hermes config set <unknown.key.path> <value> silently accepts arbitrary key paths, writes them to config.yaml, and reports success — but the runtime/gateway never reads them. The user reasonably believes their change took effect, then loses time debugging behavior that hasn't actually changed.

Reproduction

The per-platform Discord shutdown/restart notification flag lives at platforms.discord.gateway_restart_notification (defined on PlatformConfig, see gateway/config.py:299 and read at gateway/run.py:2867,2910,13178,13237).

A natural-sounding-but-wrong path is gateway.discord.gateway_restart_notification (since the docs and CLI use the word "gateway"). Running:

hermes config set gateway.discord.gateway_restart_notification false

…returns success. hermes config show | grep -A 5 discord is empty, because the value was nested under gateway: rather than platforms:. Restarting the gateway, the Discord restart notification still fires.

Expected

One of:

  • hermes config set validates section.key against the known schema (DEFAULT_CONFIG / GatewayConfig.from_dict shape) and refuses unknown keys, suggesting the closest valid path.
  • Or it auto-routes well-known per-platform flags to platforms.<name>.* with a warning.

At minimum: warn loudly on unknown keys instead of silently writing them into the YAML.

Actual

Unknown key paths are written verbatim into config.yaml with no validation, no warning, and no hint to the user that the path is wrong.

Environment

  • Hermes running in Docker container (config at /opt/data/config.yaml)
  • Discord platform

Suggested fix

Schema-validate section.key in hermes_cli/config.py before writing. Refuse unknown keys by default; add --force (or similar) to bypass for forward-compat with config keys the running version doesn't know about yet.


Filed via Hermes Agent on behalf of the user.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING