hermes - 💡(How to fix) Fix [mcp_lazy] HIGH: promote_server eager flag documented but never persisted

Severity: HIGH (correctness, silent state loss)

promote_server eager flag is documented as last-writer-wins but is never persisted.

Evidence

• plugins/mcp_lazy/pool.py:83-100 — _promoted_servers is a plain Set[str]; the eager flag passed to promote_server is never stored. Per-server eager state is only inferred from _promoted membership.
• plugins/mcp_lazy/promote.py:160 — calls promote_server(eager=...); docstring claims "last-writer-wins for the eager flag" but there is no per-server eager storage.
• The WARNING at pool.py:96 fires on every harmless idempotent re-promote, not just genuine eager conflicts (noise).

Impact

Eager-promotion intent is silently dropped; misleading docstring; spurious warnings on benign idempotent calls.

Fix

Either store eager per server (Dict[str, bool]) and honor it, or remove the eager parameter, the docstring claim, and the warning.

Filed from opus-4.8 plugin audit (mcp_lazy).