hermes - 💡(How to fix) Fix fix(dashboard): ChatPage clears header action buttons on ALL pages, not just Sessions

Problem

When the dashboard is started with embedded TUI chat enabled (hermes dashboard --tui), navigating to any non-chat page causes the page-specific header action buttons to disappear after a few seconds.

This affects at least:

• Cron page — the "CREATE" button disappears
• Models page — the "7D / 30D / 90D" filter buttons disappears

Screenshots

Cron page — normal vs buggy

Normal

Buggy

Models page — normal vs buggy

Normal

Buggy

Root Cause

ChatPage is mounted persistently outside <Routes> (so the PTY / WebSocket survive tab switches). Even when the user is on /cron, /models, or /sessions, ChatPage is still in the React tree with isActive=false.

Its useEffect for the header button actively calls setEnd(null) on every render when !isActive, clobbering the action buttons that the current page had just placed in the same slot.

The trigger for the ~3–4 second timing is the plugin load delay: usePlugins() fetches manifests asynchronously; once the promise settles, the entire tree re-renders, ChatPage's effect fires, and the header slot is wiped.

Fix

Change the effect to only register when Chat should own the slot, and let cleanup run only when it actually did:

// Before (buggy): actively clears other pages' content
useEffect(() => {
  if (!isActive) {
    setEnd(null);  // ← clears Cron CREATE button!
    return;
  }
  if (!narrow) {
    setEnd(null);  // ← also clears!
    return;
  }
  setEnd(<Button ... />);
  return () => setEnd(null);
}, [...]);

// After (fixed): only cleanup on unmount / when Chat owned the slot
useEffect(() => {
  if (!isActive || !narrow) return;  // just don't register
  setEnd(<Button ... />);
  return () => setEnd(null);  // cleanup only when Chat owned the slot
}, [...]);

PageHeaderProvider already clears all slots on pathname change via useLayoutEffect, so ChatPage's active clearing is redundant and harmful.