PR #16944: fix(auxiliary): avoid locking into custom path when api_key is empty

• Repository: NousResearch/hermes-agent
• Author: vominh1919
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16944

Description (problem / solution / changelog)

Problem

When auxiliary.<task> config has base_url set but api_key is empty (common when user expects env var fallback), _resolve_task_provider_model() returns provider="custom" with api_key=None. This causes downstream client construction to make API calls without an Authorization header, resulting in HTTP 401 errors.

This affects any user whose config has the default-looking shape from hermes setup:

auxiliary:
  title_generation:
    provider: openrouter
    model: minimax/minimax-m2.7
    base_url: https://openrouter.ai/api/v1
    api_key: ''    # empty — user expects OPENROUTER_API_KEY fallback

Root Cause

In _resolve_task_provider_model() (agent/auxiliary_client.py:2743):

if cfg_base_url:
    return "custom", resolved_model, cfg_base_url, cfg_api_key, resolved_api_mode

The if cfg_base_url: branch fires before the provider is considered. With cfg_api_key=None (empty string in YAML), the returned tuple drives _get_cached_client("custom", ..., api_key=None), which builds an OpenAI() client with no auth.

Fix

Only return the "custom" provider path when both cfg_base_url and cfg_api_key are non-empty. When base_url is set without api_key but with a known provider (e.g. "openrouter"), pass through to that provider so it can resolve credentials from environment variables.

Before

auxiliary.title_generation: base_url=https://openrouter.ai/api/v1, provider=openrouter, api_key=''
→ Returns ("custom", model, base_url, None, ...) → HTTP 401

After

auxiliary.title_generation: base_url=https://openrouter.ai/api/v1, provider=openrouter, api_key=''
→ Returns ("openrouter", model, base_url, None, ...) → resolves OPENROUTER_API_KEY from env → succeeds

Fixes #16829

Changed files

• agent/auxiliary_client.py (modified, +7/-1)

PR #16950: fix(auxiliary_client): require api_key for custom provider path

• Repository: NousResearch/hermes-agent
• Author: ztexydt-cqh
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16950

Description (problem / solution / changelog)

Problem

When auxiliary.{task} in config.yaml had provider: auto (or any value) plus a base_url set but api_key empty, _resolve_task_provider_model() fell into the custom provider branch and returned api_key=None. The downstream API call then lacked an Authorization header, causing a 401.

Root Cause

if cfg_base_url:
    return "custom", resolved_model, cfg_base_url, cfg_api_key, resolved_api_mode

The condition only checked base_url, not api_key.

Solution

Change the condition to if cfg_base_url and cfg_api_key: so that a missing/empty api_key falls through to provider auto-detection (or the explicit provider config) instead of locking into custom with no credentials.

Files Changed

• agent/auxiliary_client.py — 1-line fix
• tests/agent/test_auxiliary_client.py — 4 regression tests

Fixes #16829

Changed files

• .mailmap (modified, +3/-0)
• agent/auxiliary_client.py (modified, +1/-1)
• scripts/release.py (modified, +2/-1)
• tests/agent/test_auxiliary_client.py (modified, +63/-0)