PR #74588: Fix/browser tabcleanup schema 74577

• Repository: openclaw/openclaw
• Author: jeffrey701
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74588

Description (problem / solution / changelog)

Closes #74577.

`BrowserTabCleanupConfig` exists as a TS type, the runtime resolver
`resolveBrowserTabCleanupConfig` reads `cfg.browser.tabCleanup`, and
the dotted help/label entries (`browser.tabCleanup.enabled`,
`.idleMinutes`, `.maxTabsPerSession`, `.sweepMinutes`) are present —
but the strict zod schema for `browser` did not declare `tabCleanup`,
so any operator who tried to override the documented defaults
(`enabled=true`, `idleMinutes=120`, `maxTabsPerSession=8`,
`sweepMinutes=5`) saw their config rolled back at startup with:

    Gateway aborted: config is invalid.
    browser: Unrecognized key: "tabCleanup"

…and at hot-reload time:

    [reload] config reload restored last-known-good config after invalid-config

Defaults still applied at runtime, so cleanup *did* happen — operators
just couldn't tune it.

## Fix

Add a `tabCleanup` field to the `browser` zod object, mirroring
`BrowserTabCleanupConfig` exactly:

- `enabled: boolean | undefined`
- `idleMinutes: nonnegative integer | undefined` — `0` is a documented
  sentinel ("disable idle cleanup")
- `maxTabsPerSession: nonnegative integer | undefined` — `0` is a
  documented sentinel ("disable the cap")
- `sweepMinutes: positive integer | undefined` — must be > 0 because a
  zero-interval sweep would either spin or never fire downstream
- `.strict()` on the inner object so typos surface immediately

Regenerated `src/config/schema.base.generated.ts` (and its sha256) via
`scripts/generate-base-config-schema.ts` so the JSON-schema mirror
picks up the same shape.

## Tests

`src/config/zod-schema.browser-tab-cleanup.test.ts` adds 9 cases:

- Full documented shape parses
- Each sentinel-zero (`idleMinutes=0`, `maxTabsPerSession=0`) parses
- Partial overrides parse
- Unknown keys under `tabCleanup` are rejected
- Negative and non-integer `idleMinutes` are rejected
- `sweepMinutes <= 0` is rejected
- The surrounding browser strict-schema invariants still hold

`pnpm test src/config/zod-schema.browser-tab-cleanup.test.ts` —
9 passed. `pnpm exec oxfmt --check` — clean. `pnpm exec oxlint` —
0 warnings, 0 errors.

Closes #74577

Changed files

• docs/.generated/config-baseline.sha256 (modified, +2/-2)
• src/config/schema.base.generated.ts (modified, +39/-0)
• src/config/zod-schema.browser-tab-cleanup.test.ts (added, +130/-0)
• src/config/zod-schema.ts (modified, +20/-0)

PR #74638: config: accept browser.tabCleanup keys in zod schema (#74577)

• Repository: openclaw/openclaw
• Author: lonexreb
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/74638

Description (problem / solution / changelog)

Summary

• Problem: The browser zod schema in src/config/zod-schema.ts is .strict() and does not declare a tabCleanup field, so any operator who tries to override the runtime defaults via openclaw.json gets Gateway aborted: config is invalid. browser: Unrecognized key: "tabCleanup". The runtime resolver, the BrowserTabCleanupConfig type, the schema labels, the help text, and the generated config baseline all already advertise these keys (browser.tabCleanup.{enabled,idleMinutes,maxTabsPerSession,sweepMinutes}).
• Why it matters: As reported in #74577, operators see hot-reload roll back to last-known-good with [reload] config reload restored last-known-good config after invalid-config and there is no openclaw.json-side workaround. The defaults still apply, so cleanup happens, but operators cannot tune it.
• What changed: Added a tabCleanup field to the browser zod schema mirroring BrowserTabCleanupConfig (all fields optional, .strict() so unknown subkeys still fail closed). Regenerated src/config/schema.base.generated.ts and docs/.generated/config-baseline.sha256 per the repo drift-check workflow. Added 3 regression tests in src/config/config.schema-regressions.test.ts.
• What did NOT change (scope boundary): No runtime behavior, no resolver logic, no labels, no help text. The runtime already reads these keys via resolveBrowserTabCleanupConfig; this PR only stops the validator from rejecting them.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #74577
• Related #71165 (runtime cleanup wiring landed)
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: When the runtime cleanup wiring landed in #71165, the BrowserTabCleanupConfig type, the help text in src/config/schema.help.ts:323-331, the labels in src/config/schema.labels.ts:675-679, the resolver resolveBrowserTabCleanupConfig, and the generated baseline were all added — but the corresponding zod object property was not. With .strict() set on the browser object, any explicit override is rejected as Unrecognized.
• Missing detection / guardrail: pnpm check:base-config-schema checks that the generated JSON Schema matches the zod schema, and pnpm config:docs:check checks docs drift, but neither flagged that the help/labels referenced a path that the zod schema did not accept. A direct validateConfigObject({ browser: { tabCleanup: ... } }) regression test would have caught this; this PR adds that.
• Contributing context: The zod source of truth and the labels/help layer evolved in parallel; the help layer was already in place when the runtime resolver landed.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
• Target test or file: src/config/config.schema-regressions.test.ts
• Scenario the test should lock in:
  • Positive: validateConfigObject({ browser: { tabCleanup: { enabled, idleMinutes, maxTabsPerSession, sweepMinutes } } }) returns ok.
  • Negative on bounds: sweepMinutes: 0 is rejected (zod schema declares .positive() for sweepMinutes).
  • Negative on unknown subkey: browser.tabCleanup.unknownKey is rejected (.strict() is preserved).
• Why this is the smallest reliable guardrail: The bug is purely at the zod validation layer; a parser-level test directly on validateConfigObject is the smallest piece of code that proves both the accept and the reject paths.
• Existing test that already covers this: No.
• If no new test is added, why not: N/A (3 new tests added).

Test Plan

• pnpm test src/config/config.schema-regressions.test.ts — 21/21 pass (3 new + 18 existing)
• pnpm check:base-config-schema — clean after regenerate
• pnpm config:docs:check — clean after regenerate (docs/.generated/config-baseline.sha256 updated and committed)
• pnpm check:changed — clean (typecheck, oxlint, runtime sidecar guard, import-cycle guard, pairing/auth guards)
• pnpm exec oxfmt --write --threads=1 src/config/zod-schema.ts src/config/config.schema-regressions.test.ts src/config/schema.base.generated.ts — clean

Notes

• idleMinutes and maxTabsPerSession are nonnegative (>= 0) since 0 is a documented "disable" sentinel for these knobs in the help text. sweepMinutes is positive (> 0) because the existing runtime resolver uses normalizePositiveInteger(raw?.sweepMinutes, 5) and there is no 0 sentinel for the sweep interval.
• Subobject is also .strict() so unknown keys under browser.tabCleanup continue to fail closed, consistent with the rest of the browser schema.

Changed files

• CHANGELOG.md (modified, +1/-0)
• docs/.generated/config-baseline.sha256 (modified, +3/-3)
• src/config/config.schema-regressions.test.ts (modified, +39/-0)
• src/config/schema.base.generated.ts (modified, +39/-0)
• src/config/zod-schema.ts (modified, +9/-0)