hermes - 💡(How to fix) Fix [Bug]: ACP client hardwired for Copilot CLI — cannot use other ACP backends [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Error Message

  1. Error says "Copilot ACP command" for non-Copilot backend

Root Cause

  • _resolve_command: no HERMES_ACP_COMMAND
  • _resolve_args: always defaults to ["--acp", "--stdio"]
  • acp_args: truthiness check breaks empty list
  • _run_prompt: no shutil.which() for cross-platform
  • Messages: all hardcoded "Copilot ACP"
  • Routing: acp://copilot prefix too narrow

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Bug Description

The ACP client is tightly coupled to Copilot CLI. Cannot use claude-agent-acp or other ACP backends.

Steps to Reproduce

  1. npm install -g @agentclientprotocol/claude-agent-acp
  2. delegate_task(goal="hello", acp_command="claude-agent-acp", acp_args=[])
  3. acp_args=[] is falsy, falls through to defaults
  4. subprocess.Popen cannot find .cmd on Windows
  5. Error says "Copilot ACP command" for non-Copilot backend

Root Cause

  • _resolve_command: no HERMES_ACP_COMMAND
  • _resolve_args: always defaults to ["--acp", "--stdio"]
  • acp_args: truthiness check breaks empty list
  • _run_prompt: no shutil.which() for cross-platform
  • Messages: all hardcoded "Copilot ACP"
  • Routing: acp://copilot prefix too narrow

Proposed Fix

About 40 lines across 3 files. Generic env vars, shutil.which(), is not None checks, generic messages, acp:// routing. Backward compatible.

  • I would like to submit a PR for this

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - 💡(How to fix) Fix [Bug]: ACP client hardwired for Copilot CLI — cannot use other ACP backends [1 pull requests]