PR #16839: fix(delegate): clear acp_command when override_provider is set

• Repository: NousResearch/hermes-agent
• Author: ygd58
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16839

Description (problem / solution / changelog)

Problem

When delegation.provider is configured (e.g. minimax-cn), subagents inherited the parent's acp_command unconditionally. This caused run_agent.py to initialize CopilotACPClient, bypassing override credentials entirely and using its own default model (provider=copilot-acp model=qwen3.5-397b-a17b) instead of the configured delegation.provider and delegation.model.

Fix

When override_provider is set but override_acp_command is not explicitly provided, clear effective_acp_command and effective_acp_args so the child agent uses direct API calls with the configured provider credentials.

The existing override_acp_command path is unchanged — explicit ACP transport overrides still force provider=copilot-acp as before.

Fixes #16816

Changed files

• tools/delegate_tool.py (modified, +8/-0)

PR #16882: fix: clear acp_command when delegation.provider is configured

• Repository: NousResearch/hermes-agent
• Author: YeahloYip
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16882

Description (problem / solution / changelog)

Bug Description

When delegation.provider is configured in config.yaml (e.g., minimax-cn), subagents still inherit the parent's acp_command and use Copilot ACP transport instead of direct API calls. This causes subagents to use the wrong model and provider, bypassing the intended delegation.provider settings entirely.

Steps to Reproduce

1. Configure delegation.provider: minimax-cn and delegation.model: MiniMax-M2.7 in config.yaml
2. Start a lead agent that uses ACP transport (hermes --acp --stdio or similar)
3. Spawn a subagent via delegate_task
4. Observe the subagent's API calls — logs show provider=copilot-acp model=qwen3.5-397b-a17b instead of provider=minimax-cn model=MiniMax-M2.7

Expected Behavior

When delegation.provider is configured, subagents should use direct API calls with the configured provider's credentials (model, base_url, api_key). The parent's acp_command should NOT be inherited when a delegation provider override is set.

Actual Behavior

Subagent inherits the parent's acp_command unconditionally (delegate_tool.py:988-990):

effective_acp_command = override_acp_command or getattr(
    parent_agent, "acp_command", None
)

This causes the subagent to use Copilot ACP transport (provider=copilot-acp), whose default model is qwen3.5-397b-a17b — entirely ignoring the delegation.provider and delegation.model config.

Root Cause

In _build_child_agent(), the effective_acp_command is resolved from the parent before checking if override_provider is set. The existing comment in the code says:

When override_* params are set... the child uses those credentials instead of inheriting from the parent.

But this logic was not applied to acp_command, causing the ACP transport to override the intended delegation provider.

Fix

Clear effective_acp_command and effective_acp_args when override_provider is set. This ensures subagents use direct API calls when delegation.provider is configured.

Debug Report

Root cause location: hermes-agent/tools/delegate_tool.py, lines 988-990

Evidence from agent.log:

provider=copilot-acp model=qwen3.5-397b-a17b
Loaded env from /home/yeahlo/.hermes/profiles/coder/.env

Changed files

• tools/delegate_tool.py (modified, +7/-0)

PR #16894: fix(delegate): clear acp_command when override_provider is set

• Repository: NousResearch/hermes-agent
• Author: teknium1
• State: closed | merged: True
• Link: https://github.com/NousResearch/hermes-agent/pull/16894

Description (problem / solution / changelog)

Subagents now use direct API calls when delegation.provider is configured, instead of inheriting the parent's Copilot ACP transport.

Salvaged from #16839 by @ygd58 (buray). Duplicate PR #16882 by @YeahloYip fixed the same bug 2h18m later with a weaker guard that would nuke caller-supplied acp_command overrides; #16839's version correctly guards on not override_acp_command.

Changes

• tools/delegate_tool.py: clear effective_acp_command / effective_acp_args when override_provider is set and no explicit override_acp_command was passed. Existing explicit ACP-override path is unchanged.

Validation

• tests/tools/test_delegate.py: 120/120 passed
• E2E resolution simulation covering four paths (delegation.provider only, no-override ACP parent, explicit ACP-override + provider, non-ACP parent) all behave as expected.

Fixes #16816.

Changed files

• tools/delegate_tool.py (modified, +8/-0)