openclaw - 💡(How to fix) Fix [Bug]: Agent listener invoked outside active run causes Gateway crash [2 comments, 3 participants]

Error Stack Trace:

14:18:37+08:00 [openclaw] Unhandled promise rejection: Error: Agent listener invoked outside active run at Agent.processEvents (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/node_modules/@mariozechner/pi-agent-core/dist/agent.js:388:19) at file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/node_modules/@mariozechner/pi-agent-core/dist/agent.js:259:120 at Object.onUpdate (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/node_modules/@mariozechner/pi-agent-core/dist/agent-loop.js:336:47) at emitUpdate (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/dist/exec-defaults-uj0McX2k.js:1524:8) at handleStdout (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/dist/exec-defaults-uj0McX2k.js:1546:4) at Object.onSupervisorStdout [as onStdout] (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/dist/exec-defaults-uj0McX2k.js:1610:3) at file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/dist/exec-defaults-uj0McX2k.js:1007:21 at Socket.<anonymous> (file:///C:/Users/Grow%20up/AppData/Roaming/npm/node_modules/openclaw/dist/exec-defaults-uj0McX2k.js:568:4) at Socket.emit (node:events:508:28) at addChunk (node:internal/streams/readable:559:12)

Config: gateway.mode=local, channels: openclaw-weixin/telegram/dingtalk, 1 daily cron job at 3 AM

TL;DR

The Gateway crash due to an unhandled promise rejection from pi-agent-core can be mitigated by addressing the race condition that occurs when a session/task is ending and a new event is triggered concurrently.

Guidance

1. Review the pi-agent-core code: Examine the agent.js file, specifically line 388, to understand how the Agent listener invoked outside active run error is being thrown and consider implementing a try-catch block to handle this scenario.
2. Implement concurrency control: Introduce mechanisms to manage concurrent events, such as using locks or semaphores, to prevent the race condition that leads to the crash.
3. Enhance error handling: Improve the error handling in the Gateway to catch and handle unhandled promise rejections, preventing the process from terminating unexpectedly.
4. Test with simulated concurrent events: Develop test cases that simulate the concurrent events (session ending + heartbeat/message trigger) to ensure the fixes are effective in preventing the crash.

Example

// Example of a try-catch block to handle the error
try {
  // Code that might throw "Agent listener invoked outside active run"
  Agent.processEvents();
} catch (error) {
  // Handle the error to prevent the process from crashing
  console.error('Error processing events:', error);
}

Notes

The provided information suggests a race condition in pi-agent-core as the root cause. However, without direct access to the codebase or more detailed logs, the suggestions are based on the information given and might need further refinement.

Recommendation

Apply a workaround by implementing a try-catch block to handle the Agent listener invoked outside active run error and enhancing the concurrency control and error handling mechanisms within the Gateway. This approach is chosen because it directly addresses the identified root cause and can be implemented without waiting for a potential fix in pi-agent-core.