openclaw - ✅(Solved) Fix bug(agents): extractAssistantVisibleText leaks commentary when final_answer exists but is empty [3 pull requests, 2 comments, 1 participants]

Q: Expected behavior

If `final_answer` is present but empty, visible output should be empty — not fall back to commentary/unphased text. "No answer" is safer than surfacing chain-of-thought.

100yenadmin · 2026-04-05T18:53:35Z

[openclaw] PR 61481: fix agents : harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final answer fallback leak - Repository:… # PR #61481: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak - Repository: openclaw/openclaw - Author: 100yenadmin - State: closed | merged: False - Link: https://github.com/openclaw/openclaw/pull/61481 ## Description (problem / solution / changelog) ## Summary - fix phase-aware visible text extraction so an explicit `final_answer` block never falls back to commentary or legacy unphased text when it sanitizes to empty - suppress all commentary-phase partial streaming output regardless of whether extracted visible text is non-empty - keep session-history HTTP/SSE sanitization aligned with the hardened chat history path - add regression tests covering both leak paths and the session-history follow-through ## Context This hardens the merged #59643 behavior against two P1 leaks: - fixes #61474 - fixes #61475 ## Related issues / bug family - related to #25592 - related to #59536 - related to #59918 - related to #44213 - related to #49438 - related to #53960 ## Parent / sibling PRs - parent: #59643 — core phase-separation fix (merged) - sibling: #61463 — phase-aware extraction in sessions-helpers, TUI, and history paths ## Remaining follow-ups from the same adversarial review - #61476 — replay splitting corrupts phase on mixed messages - #61477 — late-map buffering gates on key existence, not phase validity - #61478 — function-call replay silently loses malformed arguments ## Related open PRs - #59920 — prefer terminal reply fields in CLI JSONL parser - #61151 — drop partialJson streaming artifacts from session history - #61337 — disable OpenAI tool-use pairing repair ## Testing - npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/agents/pi-embedded-utils.test.ts src/agents/pi-embedded-subscribe.handlers.messages.test.ts - npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/gateway/sessions-history-http.test.ts ## Changed files - `.agents/skills/openclaw-parallels-smoke/SKILL.md` (modified, +13/-0) - `.agents/skills/openclaw-qa-testing/SKILL.md` (added, +86/-0) - `.agents/skills/openclaw-qa-testing/agents/openai.yaml` (added, +4/-0) - `.github/labeler.yml` (modified, +4/-0) - `.github/workflows/ci.yml` (modified, +7/-1) - `.github/workflows/control-ui-locale-refresh.yml` (modified, +2/-2) - `.github/workflows/openclaw-npm-release.yml` (modified, +1/-1) - `CHANGELOG.md` (modified, +40/-12) - `appcast.xml` (modified, +248/-116) - `apps/android/app/build.gradle.kts` (modified, +2/-2) - `apps/ios/Config/Version.xcconfig` (modified, +3/-3) - `apps/macos/Sources/OpenClaw/Resources/Info.plist` (modified, +2/-2) - `apps/macos/Sources/OpenClawProtocol/GatewayModels.swift` (modified, +14/-0) - `apps/shared/OpenClawKit/Sources/OpenClawKit/Resources/tool-display.json` (modified, +23/-0) - `apps/shared/OpenClawKit/Sources/OpenClawProtocol/GatewayModels.swift` (modified, +14/-0) - `docs/.generated/config-baseline.sha256` (modified, +4/-4) - `docs/.generated/plugin-sdk-api-baseline.sha256` (modified, +2/-2) - `docs/automation/tasks.md` (modified, +5/-0) - `docs/channels/discord.md` (modified, +1/-1) - `docs/channels/matrix.md` (modified, +29/-5) - `docs/cli/memory.md` (modified, +43/-15) - `docs/cli/update.md` (modified, +3/-1) - `docs/concepts/dreaming.md` (modified, +121/-194) - `docs/concepts/memory-qmd.md` (modified, +17/-1) - `docs/concepts/memory-search.md` (modified, +9/-8) - `docs/concepts/memory.md` (modified, +12/-8) - `docs/concepts/model-providers.md` (modified, +2/-0) - `docs/concepts/models.md` (modified, +2/-0) - `docs/docs.json` (modified, +8/-1) - `docs/gateway/configuration-reference.md` (modified, +31/-12) - `docs/help/faq.md` (modified, +36/-0) - `docs/help/testing.md` (modified, +22/-0) - `docs/install/updating.md` (modified, +1/-0) - `docs/plugins/architecture.md` (modified, +1/-0) - `docs/plugins/building-plugins.md` (modified, +1/-0) - `docs/plugins/manifest.md` (modified, +76/-30) - `docs/plugins/sdk-migration.md` (modified, +11/-1) - `docs/plugins/sdk-overview.md` (modified, +22/-9) - `docs/providers/bedrock-mantle.md` (modified, +20/-7) - `docs/providers/bedrock.md` (modified, +29/-0) - `docs/providers/comfy.md` (added, +201/-0) - `docs/providers/fal.md` (modified, +2/-1) - `docs/providers/google.md` (modified, +30/-0) - `docs/providers/index.md` (modified, +4/-0) - `docs/providers/minimax.md` (modified, +29/-0) - `docs/providers/models.md` (modified, +4/-0) - `docs/providers/openai.md` (modified, +10/-2) - `docs/providers/runway.md` (added, +63/-0) - `docs/providers/vydra.md` (added, +123/-0) - `docs/reference/memory-config.md` (modified, +117/-98) - `docs/tools/image-generation.md` (modified, +21/-17) - `docs/tools/index.md` (modified, +14/-7) - `docs/tools/lobster.md` (modified

openclaw2026-04-05 18:53:35

ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

GitHub issue URL

Helpful · Quick feedback

GitHub stats

openclaw/openclaw#61474•Fetched 2026-04-08 02:58:18

View on GitHub

Comments

Participants

Timeline

Reactions

Author

100yenadmin

Participants

100yenadmin

Timeline (top)

cross-referenced ×9commented ×2closed ×1

Fix Action

Fixed

Fixed by PR: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak (https://github.com/openclaw/openclaw/pull/61481)
Fixed by PR: fix(agents,gateway): phase-aware assistant text extraction — suppress OpenAI commentary leaks in sessions-helpers, TUI, and REST history (https://github.com/openclaw/openclaw/pull/61463)
Fixed by PR: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak (https://github.com/openclaw/openclaw/pull/61829)

PR fix notes

PR #61481: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak

Repository: openclaw/openclaw
Author: 100yenadmin
State: closed | merged: False
Link: https://github.com/openclaw/openclaw/pull/61481

Description (problem / solution / changelog)

Summary

fix phase-aware visible text extraction so an explicit final_answer block never falls back to commentary or legacy unphased text when it sanitizes to empty
suppress all commentary-phase partial streaming output regardless of whether extracted visible text is non-empty
keep session-history HTTP/SSE sanitization aligned with the hardened chat history path
add regression tests covering both leak paths and the session-history follow-through

Context

This hardens the merged #59643 behavior against two P1 leaks:

fixes #61474
fixes #61475

Related issues / bug family

related to #25592
related to #59536
related to #59918
related to #44213
related to #49438
related to #53960

Parent / sibling PRs

parent: #59643 — core phase-separation fix (merged)
sibling: #61463 — phase-aware extraction in sessions-helpers, TUI, and history paths

Remaining follow-ups from the same adversarial review

#61476 — replay splitting corrupts phase on mixed messages
#61477 — late-map buffering gates on key existence, not phase validity
#61478 — function-call replay silently loses malformed arguments

Related open PRs

#59920 — prefer terminal reply fields in CLI JSONL parser
#61151 — drop partialJson streaming artifacts from session history
#61337 — disable OpenAI tool-use pairing repair

Testing

npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/agents/pi-embedded-utils.test.ts src/agents/pi-embedded-subscribe.handlers.messages.test.ts
npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/gateway/sessions-history-http.test.ts

Changed files

.agents/skills/openclaw-parallels-smoke/SKILL.md (modified, +13/-0)
.agents/skills/openclaw-qa-testing/SKILL.md (added, +86/-0)
.agents/skills/openclaw-qa-testing/agents/openai.yaml (added, +4/-0)
.github/labeler.yml (modified, +4/-0)
.github/workflows/ci.yml (modified, +7/-1)
.github/workflows/control-ui-locale-refresh.yml (modified, +2/-2)
.github/workflows/openclaw-npm-release.yml (modified, +1/-1)
CHANGELOG.md (modified, +40/-12)
appcast.xml (modified, +248/-116)
apps/android/app/build.gradle.kts (modified, +2/-2)
apps/ios/Config/Version.xcconfig (modified, +3/-3)
apps/macos/Sources/OpenClaw/Resources/Info.plist (modified, +2/-2)
apps/macos/Sources/OpenClawProtocol/GatewayModels.swift (modified, +14/-0)
apps/shared/OpenClawKit/Sources/OpenClawKit/Resources/tool-display.json (modified, +23/-0)
apps/shared/OpenClawKit/Sources/OpenClawProtocol/GatewayModels.swift (modified, +14/-0)
docs/.generated/config-baseline.sha256 (modified, +4/-4)
docs/.generated/plugin-sdk-api-baseline.sha256 (modified, +2/-2)
docs/automation/tasks.md (modified, +5/-0)
docs/channels/discord.md (modified, +1/-1)
docs/channels/matrix.md (modified, +29/-5)
docs/cli/memory.md (modified, +43/-15)
docs/cli/update.md (modified, +3/-1)
docs/concepts/dreaming.md (modified, +121/-194)
docs/concepts/memory-qmd.md (modified, +17/-1)
docs/concepts/memory-search.md (modified, +9/-8)
docs/concepts/memory.md (modified, +12/-8)
docs/concepts/model-providers.md (modified, +2/-0)
docs/concepts/models.md (modified, +2/-0)
docs/docs.json (modified, +8/-1)
docs/gateway/configuration-reference.md (modified, +31/-12)
docs/help/faq.md (modified, +36/-0)
docs/help/testing.md (modified, +22/-0)
docs/install/updating.md (modified, +1/-0)
docs/plugins/architecture.md (modified, +1/-0)
docs/plugins/building-plugins.md (modified, +1/-0)
docs/plugins/manifest.md (modified, +76/-30)
docs/plugins/sdk-migration.md (modified, +11/-1)
docs/plugins/sdk-overview.md (modified, +22/-9)
docs/providers/bedrock-mantle.md (modified, +20/-7)
docs/providers/bedrock.md (modified, +29/-0)
docs/providers/comfy.md (added, +201/-0)
docs/providers/fal.md (modified, +2/-1)
docs/providers/google.md (modified, +30/-0)
docs/providers/index.md (modified, +4/-0)
docs/providers/minimax.md (modified, +29/-0)
docs/providers/models.md (modified, +4/-0)
docs/providers/openai.md (modified, +10/-2)
docs/providers/runway.md (added, +63/-0)
docs/providers/vydra.md (added, +123/-0)
docs/reference/memory-config.md (modified, +117/-98)
docs/tools/image-generation.md (modified, +21/-17)
docs/tools/index.md (modified, +14/-7)
docs/tools/lobster.md (modified, +11/-9)
docs/tools/music-generation.md (added, +208/-0)
docs/tools/plugin.md (modified, +1/-0)
docs/tools/slash-commands.md (modified, +1/-1)
docs/tools/video-generation.md (modified, +147/-84)
docs/web/control-ui.md (modified, +4/-1)
docs/web/dashboard.md (modified, +2/-0)
dream-diary-preview-v2.html (added, +399/-0)
dream-diary-preview-v3.html (added, +323/-0)
extensions/amazon-bedrock-mantle/api.ts (modified, +2/-0)
extensions/amazon-bedrock-mantle/bedrock-token-generator.d.ts (added, +6/-0)
extensions/amazon-bedrock-mantle/discovery.test.ts (modified, +101/-3)
extensions/amazon-bedrock-mantle/discovery.ts (modified, +64/-13)
extensions/amazon-bedrock-mantle/package.json (modified, +3/-0)
extensions/bluebubbles/src/accounts.ts (modified, +5/-1)
extensions/bluebubbles/src/monitor.ts (modified, +1/-1)
extensions/browser/src/browser/chrome.default-browser.test.ts (modified, +2/-6)
extensions/browser/src/browser/client-fetch.loopback-auth.test.ts (modified, +2/-6)
extensions/browser/src/browser/control-service.plugin-disabled.test.ts (modified, +2/-6)
extensions/browser/src/browser/profiles-service.test.ts (modified, +5/-8)
extensions/browser/src/browser/pw-tools-core.clamps-timeoutms-scrollintoview.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.batch.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.evaluate.abort.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.set-input-files.test.ts (modified, +2/-4)
extensions/browser/src/browser/pw-tools-core.last-file-chooser-arm-wins.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.screenshots-element-selector.test.ts (modified, +2/-6)
extensions/browser/src/browser/routes/agent.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/routes/basic.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/server-context.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/server-context.hot-reload-profiles.test.ts (modified, +6/-12)
extensions/browser/src/browser/server-context.remote-profile-tab-ops.fallback.test.ts (modified, +2/-6)
extensions/browser/src/browser/server-context.remote-profile-tab-ops.playwright.test.ts (modified, +2/-6)
extensions/browser/src/browser/server-lifecycle.test.ts (modified, +3/-8)
extensions/browser/src/browser/server.control-server.test-harness.ts (modified, +2/-1)
extensions/browser/src/browser/server.evaluate-disabled-does-not-block-storage.test.ts (modified, +3/-8)
extensions/browser/src/cli/browser-cli.test-support.ts (modified, +1/-1)
extensions/browser/src/cli/command-format.ts (modified, +1/-1)
extensions/browser/src/config/config.ts (modified, +1/-1)
extensions/browser/src/core-api.ts (modified, +25/-20)
extensions/browser/src/doctor-browser.ts (modified, +1/-1)
extensions/browser/src/gateway/auth.ts (modified, +1/-1)
extensions/browser/src/gateway/startup-auth.ts (modified, +1/-1)
extensions/browser/src/infra/errors.ts (modified, +1/-1)
extensions/browser/src/infra/fs-safe.ts (modified, +1/-1)
extensions/browser/src/infra/net/proxy-env.ts (modified, +1/-1)
extensions/browser/src/infra/net/ssrf.ts (modified, +1/-1)
extensions/browser/src/infra/path-guards.ts (modified, +1/-1)
extensions/browser/src/infra/ports.ts (modified, +1/-1)

PR #61463: fix(agents,gateway): phase-aware assistant text extraction — suppress OpenAI commentary leaks in sessions-helpers, TUI, and REST history

Repository: openclaw/openclaw
Author: 100yenadmin
State: closed | merged: True
Link: https://github.com/openclaw/openclaw/pull/61463

Description (problem / solution / changelog)

What this fixes (plain English)

Several places in the codebase that display assistant text were not aware of the phase system (commentary vs. final answer). This meant internal "thinking out loud" commentary could leak into user-visible surfaces like the TUI and HTTP/SSE session history endpoints. This PR makes those surfaces phase-aware, and hardens heartbeat session resolution against subagent key leaks.

Technical details

Follow-up to #59643 and #59150, which fixed phase separation in the core WS path. Post-merge audit found adjacent surfaces still using phase-blind extraction.

Surfaces fixed:

src/tui/tui-formatters.ts — assistant text extraction now uses extractAssistantVisibleText() to prefer final_answer over commentary phase blocks
src/infra/heartbeat-runner.ts — heartbeat session resolution now rejects subagent session keys, falling back to the main session key instead of leaking into subagent scopes
src/gateway/sessions-history-http.test.ts — regression test: REST history applies chat.history sanitization (strips NO_REPLY messages, preserves phase blocks)
src/tui/tui-formatters.test.ts — regression test: mixed commentary + final_answer blocks extract only the visible final answer

Explicitly deferred: extractAssistantTextForSilentCheck and buffered delta/final rendering — lower-confidence, more behaviorally sensitive.

Follow-up to #59643 and #59150
Follow-up issues: #61474, #61475, #61476, #61477, #61478
Companion PRs: #61529, #61528, #61527
Related PRs: #61855, #61816

Test plan

27/27 TUI formatter tests pass
Regression test for mixed commentary + final_answer in TUI extraction
HTTP history regression test (REST path shares chat.history sanitization, strips NO_REPLY messages)
SSE seq validation for NO_REPLY message stripping
sessions-history-http gateway integration tests have 2 pre-existing infra failures (also fail on upstream/main)

Changed files

CHANGELOG.md (modified, +1/-0)
src/infra/heartbeat-runner.subagent-session-guard.test.ts (added, +72/-0)
src/infra/heartbeat-runner.ts (modified, +24/-17)
src/tui/tui-formatters.test.ts (modified, +20/-0)
src/tui/tui-formatters.ts (modified, +25/-0)

PR #61829: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak

Repository: openclaw/openclaw
Author: 100yenadmin
State: closed | merged: True
Link: https://github.com/openclaw/openclaw/pull/61829

Description (problem / solution / changelog)

Fixes #61474, #61475.

Recreated from clean branch (previous PR #61481 closed as dirty).

Summary

Prevent final_answer blocks from falling back to commentary text when sanitized to empty
Suppress all commentary-phase partial streaming output
Align session-history HTTP/SSE sanitization with hardened chat history paths
Add regression tests for leak prevention

Parent fix: #59643
Sibling PR: #61463
Initiative: #25592, #59536

Test plan

Commentary partials suppressed in streaming
Empty final_answer doesn't fall back to commentary
SSE history sanitized consistently
Bounded SSE paths sanitized

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) [email protected]

Changed files

CHANGELOG.md (modified, +1/-0)
src/agents/pi-embedded-subscribe.handlers.messages.test.ts (modified, +5/-1)
src/agents/pi-embedded-subscribe.handlers.messages.ts (modified, +11/-9)
src/agents/pi-embedded-utils.test.ts (modified, +17/-0)
src/agents/pi-embedded-utils.ts (modified, +29/-10)
src/agents/tools/chat-history-text.ts (modified, +21/-7)
src/gateway/server-methods/chat.ts (modified, +26/-4)
src/gateway/sessions-history-http.test.ts (modified, +237/-0)
src/gateway/sessions-history-http.ts (modified, +56/-17)

RAW_BUFFERClick to expand / collapse

Bug

After #59643 merged, extractAssistantVisibleText() in src/agents/pi-embedded-utils.ts:333-339 can still leak commentary as user-visible text.

Repro condition

When a mixed-phase assistant message has a final_answer block that sanitizes to empty (e.g. whitespace-only or stripped), the function falls back to extractAssistantTextForPhase(msg) with no phase argument, which returns unphased text. If the message also contains commentary blocks, that commentary can become the visible output.

Expected behavior

If final_answer is present but empty, visible output should be empty — not fall back to commentary/unphased text. "No answer" is safer than surfacing chain-of-thought.

Code location

src/agents/pi-embedded-utils.ts:333-339
The fallback path at extractAssistantTextForPhase(msg) (no phase) returns resolvedPhase === undefined blocks only, but the presence of explicit phased blocks changes unphased fallback behavior (:280-285, 297-321).

Severity

P1 — defeats the intended "prefer final_answer, suppress commentary" rule from #59643.

Parent fix: #59643
Issue: #59150

extent analysis

TL;DR

Modify the extractAssistantVisibleText() function in src/agents/pi-embedded-utils.ts to handle the case where final_answer is present but empty, ensuring it doesn't fall back to commentary or unphased text.

Guidance

Review the logic in extractAssistantVisibleText() (lines 333-339) to ensure it correctly handles the case where final_answer is empty, potentially by adding a conditional check for this scenario.
Investigate the extractAssistantTextForPhase(msg) function (particularly the no-phase argument path) to understand why it returns unphased text when final_answer is empty, and consider modifying it to return an empty string in such cases.
Consider adding a test case to cover the scenario where final_answer is present but empty, to prevent similar issues in the future.
Examine the related issues (#59150 and the parent fix #59643) for additional context on the intended behavior and potential solutions.

Example

// Example modification to extractAssistantVisibleText()
if (final_answer && final_answer.trim() === '') {
  return ''; // or some other appropriate empty value
}

Notes

The exact modification will depend on the surrounding code and the desired behavior when final_answer is empty. It's essential to review the related issues and the codebase to ensure any changes align with the intended functionality.

Recommendation

Apply a workaround by modifying the extractAssistantVisibleText() function to correctly handle the case where final_answer is present but empty, as this directly addresses the identified issue and aligns with the expected behavior outlined in the related issues.

Vote matrix · Quick signals

Works

Did the solution work? Tap to confirm.

Easy Fix

Was it a quick fix?

Time Saver

Did it save you time?

Blocking

Was it severely blocking?

Common Issue

Are others likely hitting this too?

Flaky / Intermittent

Is it intermittent?

Verified / Reproducible

Can you reproduce it reliably?

FAQ

Expected behavior

If final_answer is present but empty, visible output should be empty — not fall back to commentary/unphased text. "No answer" is safer than surfacing chain-of-thought.

#ISR setup #authentication setup #request error #file not found #serialization error

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

openclaw - ✅(Solved) Fix bug(agents): extractAssistantVisibleText leaks commentary when final_answer exists but is empty [3 pull requests, 2 comments, 1 participants]

Recommended Tools

GitHub issue graph ai analysis

Fix Action

Fixed

PR fix notes

PR #61481: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak

Description (problem / solution / changelog)

Summary

Context

Related issues / bug family

Parent / sibling PRs

Remaining follow-ups from the same adversarial review

Related open PRs

Testing

Changed files

PR #61463: fix(agents,gateway): phase-aware assistant text extraction — suppress OpenAI commentary leaks in sessions-helpers, TUI, and REST history

Description (problem / solution / changelog)

What this fixes (plain English)

Technical details

Related

Test plan

Changed files

PR #61829: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak

Description (problem / solution / changelog)

Summary

Related

Test plan

Changed files

Bug

Repro condition

Expected behavior

Code location

Severity

Related

extent analysis

TL;DR

Guidance

Example

Notes

Recommendation

FAQ

Expected behavior

Still need to ship something?

RELATED_DISCOVERY

TRENDING