PR #77818: [AI-assisted] fix: throw on registerTool without contracts.tools instead of silent failure

• Repository: openclaw/openclaw
• Author: luyao618
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/77818

Description (problem / solution / changelog)

Root Cause

api.registerTool() in src/plugins/registry.ts silently pushes a diagnostic and returns when the plugin manifest does not declare contracts.tools. The plugin's own code receives no error or warning — the only signal is a gateway-level diagnostic log (plugin must declare contracts.tools before registering agent tools) that most plugin developers never see.

This was introduced as part of the manifest-first tool contract enforcement (2026.5.2) but the enforcement path chose a non-throwing diagnostic instead of an error, making it impossible for plugins to detect the failed registration.

Fix

Replace the silent return with a throw new Error(...) in three guard paths within registerTool and registerToolMetadata:

1. No contracts.tools declared at all — throws immediately with the plugin ID and a clear message.
2. Tool names not in the declared contract — throws with the list of undeclared tool names.
3. Tool metadata for undeclared tools — throws with the undeclared tool names.

The loader's existing try/catch around register(api) catches the error and records it as a plugin load failure with a diagnostic, so the plugin is properly marked as failed and the error is surfaced in logs.

Regression Test Plan

• Existing tests in src/plugins/loader.test.ts ("rejects plugin tool registration without manifest tool ownership" and "rejects plugin tool names outside the manifest tool contract") updated to match the new error message format.
• All 123 tests in loader.test.ts pass.
• The throw does not change the external contract: registerTool return type remains void, and the loader already handles thrown errors from plugin register() calls.

Security Impact

None. This change makes a silent failure loud — it does not alter any security boundary or access control.

Closes #77800

Changed files

• src/plugins/loader.test.ts (modified, +4/-2)
• src/plugins/registry.ts (modified, +9/-3)

PR #78084: fix: support dynamic plugin tool contracts

• Repository: openclaw/openclaw
• Author: bryce-d-greybeard
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/78084

Description (problem / solution / changelog)

Summary

Fixes dynamic plugin tool ownership without reverting the manifest-first plugin contract.

Plugins still must declare contracts.tools, but they can now declare a bounded terminal wildcard namespace such as acme_*. Runtime api.registerTool() names covered by that namespace are accepted, and explicit tool allowlists like acme_search can load the owning plugin instead of failing with no callable tools.

Changes

• Add terminal wildcard matching for plugin tool contracts (prefix_*).
• Keep bare * from becoming catch-all ownership.
• Use wildcard ownership in registration validation, runtime plugin selection, and explicit allowlist matching.
• Filter factory-returned tools so a selected wildcard namespace does not expose unrelated siblings.
• Add loader and plugin tool resolution regression tests.
• Document dynamic namespace ownership in plugin manifest docs.

Testing

• PATH="/tmp/openclaw-pnpm-shim:$PATH" pnpm vitest run src/plugins/loader.test.ts src/plugins/tools.optional.test.ts — passed, 183 tests.
• git diff --check — passed.
• PATH="/tmp/openclaw-pnpm-shim:$PATH" node scripts/check-changed.mjs — passed through pairing store guard, then SIGKILLed before/at final pairing-account guard on this host. Standalone PATH="/tmp/openclaw-pnpm-shim:$PATH" node scripts/check-pairing-account-scope.mjs passed.

Fixes #77800

Changed files

• docs/plugins/manifest.md (modified, +3/-1)
• src/plugins/loader.test.ts (modified, +42/-0)
• src/plugins/tool-contracts.ts (modified, +36/-2)
• src/plugins/tools.optional.test.ts (modified, +40/-0)
• src/plugins/tools.ts (modified, +32/-7)