PR #81454: fix(agents): honor disabled reasoning in thinking policy

• Repository: openclaw/openclaw
• Author: giodl73-repo
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/81454

Description (problem / solution / changelog)

Summary

Fixes #81424 by making an explicit configured model reasoning: false authoritative for thinking policy.

Before this change, configured Google/Gemma models with reasoning: false could still resolve a visible/default thinking policy such as thinking=medium, because the policy resolver only used provider thinking hooks and did not consult configured provider model metadata on the synchronous startup path. The Google transport already guarded against model.reasoning === false; this aligns startup/session thinking policy with that same resolved model capability. Scope note: this branch also carries small CI guardrail/test-fixture updates that were needed to keep the focused thinking-policy change green under the current strictness checks: plugin registry/runtime-config typing strictness and the plugin SDK package-contract guardrail pattern update. Those changes are test/strictness alignment for the same CI run, not new runtime behavior for the thinking-policy fix.

Real behavior proof

Behavior addressed: Configured Google/Gemma models with reasoning: false show thinking=off in startup/session policy and do not send Google generationConfig.thinkingConfig, even if a stale/default reasoning: "medium" option reaches the Google payload builder.

Real environment tested: Local Windows source checkout, rebased branch fix-google-no-thinking-policy.

Exact steps or command run after this patch:

node --import tsx <proof-script>
pnpm test src/auto-reply/thinking.test.ts src/agents/model-selection.test.ts src/gateway/server-startup-log.test.ts extensions/google/transport-stream.test.ts extensions/google/index.test.ts -- --reporter=verbose
pnpm exec oxfmt --check --threads=1 CHANGELOG.md src/auto-reply/thinking.ts src/auto-reply/thinking.test.ts src/agents/model-thinking-default.ts src/agents/model-selection.test.ts src/gateway/server-startup-log.ts src/gateway/server-startup-log.test.ts extensions/google/transport-stream.test.ts
git diff --check

Evidence after fix:

The proof script imports the patched formatAgentModelStartupDetails(...) and buildGoogleGenerativeAiParams(...), configures google/gemma-4-26b-a4b-it with reasoning: false, and passes a stale reasoning: "medium" option into the Google payload builder.

$ node --import tsx <proof-script>
{
  "startupDetails": "thinking=off, fast=off",
  "hasThinkingConfig": false,
  "generationConfig": {
    "maxOutputTokens": 128
  }
}

Targeted regression output:

✓ gateway startup log > shows thinking off for configured provider models with reasoning disabled
✓ model-selection > resolveThinkingDefault > honors configured provider models that disable reasoning
✓ google transport stream > does not send thinkingConfig when the resolved Google model disables reasoning

Test Files  5 passed (5)
Tests  185 passed (185)
[test] passed 4 Vitest shards in 46.14s

Observed result after fix: The startup formatter reports thinking=off, and the Google request payload contains only maxOutputTokens in generationConfig; no thinkingConfig is emitted for the configured non-reasoning Gemma model.

What was not tested: This proof does not call the live Google API or a Telegram-triggered hosted Gateway. It proves the local startup/policy and Google payload-building paths that produced the bad request shape.

Tests

• pnpm test src/auto-reply/thinking.test.ts src/agents/model-selection.test.ts src/gateway/server-startup-log.test.ts extensions/google/transport-stream.test.ts extensions/google/index.test.ts -- --reporter=verbose
• pnpm exec oxfmt --check --threads=1 CHANGELOG.md src/auto-reply/thinking.ts src/auto-reply/thinking.test.ts src/agents/model-thinking-default.ts src/agents/model-selection.test.ts src/gateway/server-startup-log.ts src/gateway/server-startup-log.test.ts extensions/google/transport-stream.test.ts
• git diff --check

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/google/transport-stream.test.ts (modified, +17/-0)
• src/agents/model-selection.test.ts (modified, +32/-0)
• src/agents/model-thinking-default.ts (modified, +7/-6)
• src/auto-reply/thinking.test.ts (modified, +32/-0)
• src/auto-reply/thinking.ts (modified, +10/-0)
• src/gateway/server-startup-log.test.ts (modified, +30/-0)
• src/gateway/server-startup-log.ts (modified, +19/-1)
• src/plugins/contracts/plugin-sdk-package-contract-guardrails.test.ts (modified, +1/-0)
• src/plugins/registry.runtime-config.test.ts (modified, +3/-2)
• src/plugins/registry.ts (modified, +3/-3)