PR #23460: fix(transports/codex): remove unsupported include parameter for standard OpenAI Chat Completions API

• Repository: NousResearch/hermes-agent
• Author: liuhao1024
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23460

Description (problem / solution / changelog)

Summary

Fixes #23450: OpenAI Chat Completions API does not support the include parameter, causing HTTP 400 errors when Hermes sends include: [reasoning.encrypted_content] to the standard Chat Completions endpoint.

Root Cause

In agent/transports/codex.py, the build_kwargs() method unconditionally sets:

kwargs["include"] = ["reasoning.encrypted_content"]

for general backends (non-xAI, non-GitHub Responses) when reasoning is enabled. This is incorrect for:

• Standard OpenAI Chat Completions API (api.openai.com/v1) - does NOT support the include parameter
• Other general backends that may not support encrypted content

The include parameter with reasoning.encrypted_content is only valid for:

• xAI backend (already gated per model in #23106)
• GitHub Responses API (handles it separately)

Fix

• Removed kwargs["include"] = ["reasoning.encrypted_content"] for general backends
• Added explanatory comment about backend-specific include parameter support
• The reasoning parameter is still sent to general backends (OpenAI supports it)
• The elif not is_github_responses and not is_xai_responses: kwargs["include"] = [] line remains for when reasoning is disabled

Regression Coverage

Added TestCodexIncludeParameterGating class with 4 tests:

• test_openai_chat_completions_no_include_when_enabled - verifies standard OpenAI API does NOT receive include parameter (but does receive reasoning)
• test_xai_include_with_reasoning_enabled - verifies xAI backend still receives include parameter (preserving #23106 behavior)
• test_github_responses_no_include_without_extra - verifies GitHub Responses does NOT receive include without github_reasoning_extra
• test_github_responses_reasoning_without_include - verifies GitHub Responses can use reasoning but not include

All 28 tests in test_codex_transport.py pass.

Related Issues

• #23450: This fix
• #23106: xAI reasoning.effort gating (same class of bug, different backend)
• #23088: Original xAI bug report

Test Plan

• python -m pytest tests/agent/transports/test_codex_transport.py -v — 28 passed
• Verified xAI tests still pass (preserving #23106 behavior)
• Verified GitHub Responses tests still pass
• Manual verification: standard OpenAI Chat Completions API no longer receives include parameter

Changed files

• agent/transports/codex.py (modified, +2/-1)
• gateway/platforms/whatsapp.py (modified, +4/-1)
• tests/agent/transports/test_codex_transport.py (modified, +70/-0)
• tests/tools/test_file_tools.py (modified, +37/-0)
• tools/file_tools.py (modified, +6/-6)