PR #72367: fix: clean up bundled LSP process trees on shutdown

• Repository: openclaw/openclaw
• Author: ai-hpc
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/72367

Description (problem / solution / changelog)

Summary

• Problem: Bundled stdio LSP servers could leave nested child processes such as tsserver running after run cleanup or Gateway shutdown.
• Why it matters: Orphaned language-server children can keep consuming memory after OpenClaw has stopped or restarted.
• What changed: Bundle LSP servers now spawn as disposable process groups, cleanup terminates the process tree, and Gateway shutdown sweeps active bundle LSP runtimes with bounded grace handling.
• What did NOT change (scope boundary): No plugin manifest format, LSP tool schema, model/provider routing, or user config behavior changed.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #72357
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: Bundle LSP disposal only terminated the immediate LSP process, and Gateway shutdown did not have a global active bundle-LSP runtime sweep.
• Missing detection / guardrail: There was no regression test proving nested LSP process trees are terminated or that Gateway shutdown invokes bundle-LSP cleanup.
• Contributing context (if known): Existing Gateway shutdown already swept bundle MCP runtimes, but bundle LSP runtimes were per-run only.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/agents/pi-bundle-lsp-runtime.test.ts, src/gateway/server-close.test.ts
• Scenario the test should lock in: Bundle LSP processes are spawned as disposable process groups, cleanup uses process-tree termination, and Gateway shutdown calls the active bundle-LSP sweep.
• Why this is the smallest reliable guardrail: The bug is in local runtime lifecycle and Gateway shutdown plumbing, so mocked process and shutdown tests cover the failing contract without a live TypeScript server.
• Existing test that already covers this (if any): None.
• If no new test is added, why not: N/A.

User-visible / Behavior Changes

Stopping or restarting the Gateway now also cleans up active bundled LSP process trees, including nested children such as tsserver.

Diagram (if applicable)

Before:
[Gateway stop] -> [run/gateway cleanup] -> [immediate LSP process killed] -> [nested tsserver may remain]

After:
[Gateway stop] -> [bundle LSP shutdown sweep] -> [process tree terminated] -> [nested tsserver exits]

## Changed files

- `src/agents/pi-bundle-lsp-runtime.test.ts` (added, +141/-0)
- `src/agents/pi-bundle-lsp-runtime.ts` (modified, +108/-36)
- `src/gateway/server-close.test.ts` (modified, +59/-0)
- `src/gateway/server-close.ts` (modified, +34/-11)


---

# PR #72530: fix(lsp): kill entire process group on LSP session cleanup

- Repository: openclaw/openclaw
- Author: ottodeng
- State: open | merged: False
- Link: https://github.com/openclaw/openclaw/pull/72530

## Description (problem / solution / changelog)

## Summary

Fixes #72357 — bundled LSP `tsserver` child processes persist after gateway stop.

## Root cause

`typescript-language-server` spawns `tsserver` as a nested child process. The current cleanup code calls `session.process.kill()` which only sends SIGTERM to the direct child (`typescript-language-server`), leaving `tsserver` orphaned and consuming memory.

## Fix

1. **Spawn LSP processes in their own process group** (`detached: true` on Unix) so the entire tree can be addressed with a single signal
2. **Send SIGTERM to the process group** (`process.kill(-pid, 'SIGTERM')`) in `disposeSession()` before falling through to the direct `process.kill()`

On Windows, `ChildProcess.kill()` already terminates the process tree, so `detached` and negative-PID signaling are skipped.

## Changes

- `src/agents/pi-bundle-lsp-runtime.ts`: Added `detached: !isWindows` to spawn options; added process group kill in `disposeSession()`

## Testing

- TypeScript compilation passes with no errors
- Process group kill is wrapped in try/catch for robustness (group may already be gone)

## Changed files

- `src/agents/pi-bundle-lsp-runtime.test.ts` (added, +99/-0)
- `src/agents/pi-bundle-lsp-runtime.ts` (modified, +56/-1)