Issue Station
Sign In
Tools hereToolbox

openclaw - 💡(How to fix) Fix [Bug]: Channel streaming started flag set before async onStart completes [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

In src/plugin-sdk/channel-streaming.ts:459-476, started = true is set synchronously before params.onStart resolves.

Error Message

If the timer-triggered onStart rejects, the error is swallowed and noteWork() returns true (thinks streaming is active) when onStart never completed. Downstream code believes the stream is live when it is not, potentially causing silent message loss or stale state.

Root Cause

In src/plugin-sdk/channel-streaming.ts:459-476, started = true is set synchronously before params.onStart resolves.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Summary

In src/plugin-sdk/channel-streaming.ts:459-476, started = true is set synchronously before params.onStart resolves.

Impact

If the timer-triggered onStart rejects, the error is swallowed and noteWork() returns true (thinks streaming is active) when onStart never completed. Downstream code believes the stream is live when it is not, potentially causing silent message loss or stale state.

Suggested fix

Set started = true only after onStart resolves, or reset it to false on rejection.

Found by

Codebase audit (finding F020).

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#runtime error#dependency conflict#environment setup#docker error#permission error

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

openclaw - 💡(How to fix) Fix [Bug]: Channel streaming started flag set before async onStart completes [1 pull requests]