PR #71950: fix(gateway): guard networkInterfaces calls against sandbox SystemError [AI-assisted]

• Repository: openclaw/openclaw
• Author: luyao618
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/71950

Description (problem / solution / changelog)

🤖 AI-assisted (built with Claude Code via Hermes orchestration). Test level: fully tested. Prompt summary available on request.

Summary

• Problem: In sandboxed environments (Docker/Nemoclaw/OpenShell), os.networkInterfaces() throws SystemError: uv_interface_addresses returned Unknown system error 1, crashing the gateway and preventing TUI connection.
• Why it matters: Gateway becomes completely unusable in any sandboxed environment that restricts network interface enumeration.
• What changed: Two callers switched from the unsafe readNetworkInterfaces() to the safe safeNetworkInterfaces() variant that catches errors and returns undefined. Corresponding tests updated to assert graceful fallback behavior.
• What did NOT change (scope boundary): The readNetworkInterfaces() and safeNetworkInterfaces() functions themselves are unchanged. No other callers or unrelated code was modified.

Change Type (select all)

• Bug fix

Scope (select all touched areas)

• Gateway
• Infrastructure

Linked Issue/PR

• Closes #71721
• This PR fixes a bug or regression

Root Cause

• Root cause: src/gateway/net.ts and src/infra/tailnet.ts called readNetworkInterfaces() which directly invokes os.networkInterfaces() without error handling. In sandboxed environments, this OS call throws a SystemError because uv_interface_addresses is unavailable.
• Missing detection / guardrail: The codebase already had safeNetworkInterfaces() (with try/catch) but the two gateway-critical callers used the unsafe variant.
• Contributing context: The safe variant existed and was used by src/pairing/setup-code.ts, but gateway/net.ts and infra/tailnet.ts were written before or without awareness of the sandbox failure mode.

Regression Test Plan

• Coverage level that should have caught this:
  • Unit test
• Target test or file: src/gateway/net.test.ts, src/infra/tailnet.test.ts
• Scenario the test should lock in: When os.networkInterfaces() throws, pickPrimaryLanIPv4() returns undefined and listTailnetAddresses() returns empty arrays instead of propagating the error.
• Why this is the smallest reliable guardrail: Tests mock os.networkInterfaces to throw, verifying the exact failure path reported in the issue.
• Existing test that already covers this: Updated existing tests that previously asserted throw behavior to now assert graceful fallback.
• If no new test is added, why not: N/A — existing tests were updated to cover the new behavior.

User-visible / Behavior Changes

• Gateway no longer crashes in sandboxed environments that restrict os.networkInterfaces(). Network-dependent features (LAN IP display, Tailnet detection) gracefully degrade to unavailable instead of crashing the process.

Diagram (if applicable)

N/A

Security Impact (required)

• New permissions/capabilities? No
• This fix only changes error handling to return undefined/empty instead of throwing. No new capabilities, no change to data flow, no security surface change.

Changed files

• src/gateway/net.test.ts (modified, +2/-2)
• src/gateway/net.ts (modified, +2/-2)
• src/infra/tailnet.test.ts (modified, +4/-2)
• src/infra/tailnet.ts (modified, +2/-2)