PR #58872: fix(cron): avoid busy-wait drift for recurring main jobs

• Repository: openclaw/openclaw
• Author: scoootscooob
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/58872

Description (problem / solution / changelog)

Summary

• Problem: recurring main-session cron jobs with --wake now stay inside the cron run while runHeartbeatOnce keeps returning requests-in-flight, which inflates lastDurationMs and lets schedule drift accumulate.
• Why it matters: short recurring jobs like */3 * * * * can appear to run for minutes and miss later slots even with --exact.
• What changed: recurring main-session jobs now fall back to requestHeartbeatNow() immediately after the first busy runHeartbeatOnce result instead of busy-waiting in the cron lane.
• What did NOT change (scope boundary): one-shot --at jobs still keep the existing synchronous wait-for-heartbeat behavior.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #58833
• Related #58833
• This PR fixes a bug or regression

Root Cause / Regression History (if applicable)

• Root cause: executeMainSessionCronJob() retried runHeartbeatOnce() for up to the busy-wait window even for recurring jobs, so the cron run duration included main-lane contention instead of just cron scheduling work.
• Missing detection / guardrail: there was coverage for one-shot wakeMode=now behavior, but no regression test for recurring main-session jobs under requests-in-flight pressure.
• Prior context (git blame, prior PR, issue, or refactor if known): Unknown.
• Why this regressed now: under heavier gateway load, recurring cron jobs can hit the busy main lane path repeatedly, which magnifies duration inflation and drift.
• If unknown, what was ruled out: the per-job cron stagger path and post-run duration math were not the primary cause here.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/cron/service.issue-regressions.test.ts
• Scenario the test should lock in: a recurring main-session cron job with wakeMode="now" and runHeartbeatOnce() returning requests-in-flight should request a queued heartbeat immediately and complete with a short recorded duration.
• Why this is the smallest reliable guardrail: it exercises the exact scheduler path without requiring broader gateway/runtime setup.
• Existing test that already covers this (if any): src/cron/service.runs-one-shot-main-job-disables-it.test.ts covers one-shot wakeMode now behavior, but not recurring jobs.
• If no new test is added, why not: N/A

User-visible / Behavior Changes

Recurring main-session cron jobs using --wake now no longer sit in a long busy-wait loop when the main lane is already busy. Their cron run finishes quickly after queueing the immediate heartbeat, which keeps lastDurationMs closer to scheduler overhead and reduces drift from blocked cron slots.

Diagram (if applicable)

Before:
[recurring cron due] -> [enqueue system event] -> [busy runHeartbeatOnce loop] -> [minutes counted as cron duration] -> [later slots drift]

After:
[recurring cron due] -> [enqueue system event] -> [first busy runHeartbeatOnce] -> [requestHeartbeatNow] -> [cron run completes quickly]

Security Impact (required)

• New permissions/capabilities? (Yes/No) No
• Secrets/tokens handling changed? (Yes/No) No
• New/changed network calls? (Yes/No) No
• Command/tool execution surface changed? (Yes/No) No
• Data access scope changed? (Yes/No) No
• If any Yes, explain risk + mitigation:

Repro + Verification

Environment

• OS: macOS
• Runtime/container: local test runner
• Model/provider: N/A
• Integration/channel (if any): N/A
• Relevant config (redacted): recurring main-session cron job with wakeMode=now

Steps

1. Create a recurring main-session cron job with wakeMode=now.
2. Make runHeartbeatOnce() return { status: "skipped", reason: "requests-in-flight" }.
3. Execute the job and inspect the recorded result.

Expected

• The cron job should enqueue the event, request an immediate heartbeat, and finish quickly.

Actual

• Before this change, the cron job stayed in the busy-wait retry loop and recorded an inflated duration.

Evidence

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Human Verification (required)

• Verified scenarios: ran pnpm test -- src/cron/service.issue-regressions.test.ts -t "#58833|busy-recurring-main|main lane is busy" and pnpm test -- src/cron/service.runs-one-shot-main-job-disables-it.test.ts -t "wakeMode now".
• Edge cases checked: confirmed the existing one-shot wakeMode now tests still pass, so the synchronous one-shot behavior remains intact.
• What you did not verify: full repo-wide pnpm check is currently failing due to unrelated existing tsgo errors outside the cron surface.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes/No) Yes
• Config/env changes? (Yes/No) No
• Migration needed? (Yes/No) No
• If yes, exact upgrade steps:

Risks and Mitigations

• Risk: recurring main-session jobs now stop waiting sooner when the main lane is busy, so their cron run status reflects successful queueing rather than completed main-lane processing.
  • Mitigation: the change is limited to recurring jobs; one-shot jobs keep the existing wait-for-heartbeat behavior, and the new regression test locks in the intended fallback path.

Changed files

• src/cron/service.issue-regressions.test.ts (modified, +55/-0)
• src/cron/service/timer.ts (modified, +12/-0)

PR #58725: Fix: slash commands ignored when wrapped by metadata text (Resolves #58674)

• Repository: openclaw/openclaw
• Author: Mlightsnow
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/58725

Description (problem / solution / changelog)

Fixes #58674.

Problem

Slash commands like /model spark and /new spark were silently ignored when the inbound message body included metadata prefix blocks (e.g. Conversation info (untrusted metadata):, Sender (untrusted metadata):, timestamps) injected by buildInboundUserContextPrefix. This happened because normalizeCommandBody returns text unchanged when it doesn't start with /, so metadata-wrapped commands were never parsed.

Fix

Applied stripInboundMetadata() (which already exists in strip-inbound-meta.ts) before calling normalizeCommandBody() in three locations:

• hasControlCommand() in command-detection.ts
• isControlCommandMessage() in command-detection.ts
• parseSendPolicyCommand() in send-policy.ts

Tests

Added 3 test cases to command-control.test.ts covering:

• Commands wrapped in Conversation info metadata blocks
• Commands after Sender metadata prefix
• Commands after timestamp + metadata prefix

Changed files

• .agents/skills/openclaw-parallels-smoke/SKILL.md (modified, +6/-2)
• .agents/skills/openclaw-release-maintainer/SKILL.md (modified, +21/-11)
• .github/workflows/openclaw-npm-release.yml (modified, +57/-1)
• .github/workflows/plugin-npm-release.yml (modified, +3/-0)
• .markdownlint-cli2.jsonc (modified, +3/-0)
• AGENTS.md (modified, +1/-1)
• CHANGELOG.md (modified, +330/-163)
• CONTRIBUTING.md (modified, +4/-1)
• Dockerfile (modified, +1/-1)
• Makefile (added, +4/-0)
• README.md (modified, +44/-3)
• SECURITY.md (modified, +5/-1)
• appcast.xml (modified, +117/-42)
• apps/android/app/build.gradle.kts (modified, +2/-2)
• apps/android/app/src/main/java/ai/openclaw/app/MainViewModel.kt (modified, +1/-0)
• apps/android/app/src/main/java/ai/openclaw/app/ui/ConnectTabScreen.kt (modified, +8/-3)
• apps/android/app/src/main/java/ai/openclaw/app/ui/GatewayConfigResolver.kt (modified, +19/-5)
• apps/android/app/src/main/java/ai/openclaw/app/ui/OnboardingFlow.kt (modified, +5/-2)
• apps/android/app/src/test/java/ai/openclaw/app/ui/GatewayConfigResolverTest.kt (modified, +82/-6)
• apps/android/app/src/test/java/ai/openclaw/app/ui/OnboardingFlowLogicTest.kt (added, +27/-0)
• apps/ios/Config/Version.xcconfig (modified, +3/-3)
• apps/ios/README.md (modified, +3/-3)
• apps/ios/Sources/Gateway/GatewaySettingsStore.swift (modified, +20/-0)
• apps/ios/Sources/Model/NodeAppModel.swift (modified, +149/-13)
• apps/ios/Sources/Settings/SettingsTab.swift (modified, +5/-0)
• apps/ios/Tests/GatewayConnectionSecurityTests.swift (modified, +19/-2)
• apps/ios/Tests/NodeAppModelInvokeTests.swift (modified, +58/-0)
• apps/macos/Sources/OpenClaw/AppState.swift (modified, +13/-0)
• apps/macos/Sources/OpenClaw/Constants.swift (modified, +1/-0)
• apps/macos/Sources/OpenClaw/GatewayConnection.swift (modified, +4/-0)
• apps/macos/Sources/OpenClaw/HostEnvSecurityPolicy.generated.swift (modified, +45/-0)
• apps/macos/Sources/OpenClaw/Resources/Info.plist (modified, +2/-2)
• apps/macos/Sources/OpenClaw/TalkModeController.swift (modified, +6/-0)
• apps/macos/Sources/OpenClaw/TalkModeRuntime.swift (modified, +6/-0)
• apps/macos/Sources/OpenClaw/VoiceWakeRuntime.swift (modified, +18/-1)
• apps/macos/Sources/OpenClaw/VoiceWakeSettings.swift (modified, +10/-0)
• apps/macos/Sources/OpenClawDiscovery/WideAreaGatewayDiscovery.swift (modified, +22/-74)
• apps/macos/Tests/OpenClawIPCTests/WideAreaGatewayDiscoveryTests.swift (modified, +79/-1)
• apps/shared/OpenClawKit/Sources/OpenClawKit/GatewayTLSPinning.swift (modified, +31/-0)
• docs/.generated/config-baseline.json (modified, +852/-475)
• docs/.generated/config-baseline.jsonl (modified, +104/-76)
• docs/.generated/plugin-sdk-api-baseline.json (modified, +131/-131)
• docs/.generated/plugin-sdk-api-baseline.jsonl (modified, +125/-125)
• docs/assets/sponsors/blacksmith-light.svg (added, +14/-0)
• docs/assets/sponsors/convex-light.svg (added, +16/-0)
• docs/assets/sponsors/nvidia-dark.svg (added, +9/-0)
• docs/assets/sponsors/nvidia.svg (added, +9/-0)
• docs/assets/sponsors/openai-light.svg (added, +3/-0)
• docs/assets/sponsors/vercel-light.svg (added, +5/-0)
• docs/automation/clawflow.md (modified, +47/-0)
• docs/automation/cron-jobs.md (modified, +3/-1)
• docs/automation/hooks.md (modified, +5/-0)
• docs/automation/tasks.md (modified, +14/-0)
• docs/channels/feishu.md (modified, +32/-0)
• docs/channels/index.md (modified, +1/-1)
• docs/channels/matrix.md (modified, +1/-0)
• docs/channels/msteams.md (modified, +13/-0)
• docs/channels/qqbot.md (modified, +48/-15)
• docs/channels/troubleshooting.md (modified, +13/-0)
• docs/channels/whatsapp.md (modified, +27/-1)
• docs/cli/acp.md (modified, +2/-1)
• docs/cli/cron.md (modified, +1/-1)
• docs/cli/flows.md (modified, +1/-1)
• docs/cli/plugins.md (modified, +12/-0)
• docs/cli/skills.md (modified, +4/-0)
• docs/concepts/model-failover.md (modified, +8/-0)
• docs/concepts/models.md (modified, +1/-0)
• docs/gateway/configuration-reference.md (modified, +4/-0)
• docs/gateway/discovery.md (modified, +2/-0)
• docs/gateway/doctor.md (modified, +8/-0)
• docs/gateway/security/index.md (modified, +5/-1)
• docs/gateway/tools-invoke-http-api.md (modified, +25/-9)
• docs/gateway/trusted-proxy-auth.md (modified, +12/-0)
• docs/help/faq.md (modified, +2/-0)
• docs/help/testing.md (modified, +2/-2)
• docs/install/development-channels.md (modified, +3/-3)
• docs/platforms/mac/skills.md (modified, +1/-0)
• docs/platforms/macos.md (modified, +2/-0)
• docs/plugins/architecture.md (modified, +2/-0)
• docs/plugins/sdk-channel-plugins.md (modified, +22/-2)
• docs/providers/bedrock.md (modified, +41/-0)
• docs/reference/RELEASING.md (modified, +6/-2)
• docs/reference/prompt-caching.md (modified, +14/-4)
• docs/reference/secretref-credential-surface.md (modified, +0/-4)
• docs/reference/secretref-user-supplied-credentials-matrix.json (modified, +0/-28)
• docs/start/openclaw.md (modified, +7/-4)
• docs/tools/acp-agents.md (modified, +2/-0)
• docs/tools/exec-approvals.md (modified, +1/-1)
• docs/tools/exec.md (modified, +1/-1)
• docs/tools/lobster.md (modified, +2/-0)
• docs/tools/plugin.md (modified, +11/-0)
• docs/tools/skills.md (modified, +2/-0)
• docs/tools/slash-commands.md (modified, +2/-0)
• docs/tools/web.md (modified, +37/-0)
• extensions/acpx/package.json (modified, +2/-2)
• extensions/acpx/src/runtime-internals/process.test.ts (modified, +30/-0)
• extensions/acpx/src/runtime-internals/process.ts (modified, +8/-1)
• extensions/acpx/src/runtime.test.ts (modified, +78/-0)
• extensions/acpx/src/runtime.ts (modified, +29/-2)
• extensions/acpx/src/service.test.ts (modified, +134/-0)