hermes - 💡(How to fix) Fix Bug: cron.jobs.update_job crashes when schedule updates use raw string form [1 participants]

Summary

cron.jobs.update_job() crashes when a caller updates schedule using the raw string form that the API layer accepts (for example "0 * * * *"). The function assumes updated["schedule"] is a parsed schedule dict and immediately calls .get() on it.

Affected code

• cron/jobs.py:487-516
• especially cron/jobs.py:502-509
• API expectation nearby: tests/gateway/test_api_server_jobs.py:288-312 patches the API with json={"name": "updated-name", "schedule": "0 * * * *"}

Why this is a bug

The public API shape already allows string schedules, but update_job() only works if the caller pre-parses the schedule into a dict. A PATCH that changes only the schedule can therefore explode with AttributeError instead of updating the job.

Minimal reproduction

import os
import tempfile
from cron.jobs import create_job, update_job

with tempfile.TemporaryDirectory() as td:
    os.environ["HERMES_HOME"] = td
    job = create_job(name="demo", prompt="x", schedule="30m")
    update_job(job["id"], {"schedule": "0 * * * *"})

Actual exception:

AttributeError: 'str' object has no attribute 'get'

Expected behavior

• update_job() should accept the same string schedule shape as create_job() / the API PATCH payload and normalize it before reading derived fields.

Actual behavior

• The update path crashes on updated_schedule.get(...).

Suggested investigation

Normalize or parse updates["schedule"] before deriving schedule_display / next_run_at, and add a regression test that exercises update_job(job_id, {"schedule": "0 * * * *"}) directly (not just a mocked API patch).