PR #51381: fix(ui): prevent double-qualifying already-qualified model values

• Repository: openclaw/openclaw
• Author: Cypherm
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/51381

Description (problem / solution / changelog)

Summary

Problem: When switching models in the Control UI, resolveServerChatModelValue() blindly prepends the session's default provider to the model string — even when it's already provider-qualified (e.g. ollama/gpt-oss:120b-cloud). This produces invalid refs like anthropic/ollama/gpt-oss:120b-cloud, which the server rejects with model not allowed.

Why it matters: Users with multi-provider setups (Ollama + Anthropic, OpenRouter nested models) cannot switch models in the Control UI without hitting this error.

What changed:

• Rewrote resolveServerChatModelValue() to use startsWith(provider + "/") guard instead of delegating to buildQualifiedChatModelValue
• buildQualifiedChatModelValue() is unchanged — it remains a general-purpose builder
• Added test cases for Together vendor-prefixed IDs, OpenRouter nested IDs, and already-qualified detection
• Added chat-model-ref.test.ts to vitest include list

What did NOT change:

• buildQualifiedChatModelValue() is untouched — this PR only changes the call site that resolves server-bound model values
• normalizeChatModelOverrideValue(), formatChatModelDisplay(), buildChatModelOption() are untouched
• No changes to server-side model resolution or validation

Change Type

• Bug fix (non-breaking)

Scope

UI/DX (Control UI model picker)

Linked Issue

Closes #51139 Closes #51306 Closes #51809 Closes #52002 Closes #52061 Closes #52127 Closes #52173 Closes #52474

Security Impact

• New permissions requested: none
• Secrets handling changes: none
• New network calls: none
• New command/tool execution: none
• Data access changes: none

Human Verification

I personally verified:

• pnpm build passes
• pnpm test -- ui/src/ui/chat-model-ref.test.ts — 8/8 tests pass (5 existing + 3 new)
• New test: resolveServerChatModelValue("ollama/gpt-oss:120b-cloud", "anthropic") returns "ollama/gpt-oss:120b-cloud" (not "anthropic/ollama/gpt-oss:120b-cloud")
• New test: resolveServerChatModelValue("openrouter/anthropic/claude-sonnet-4-6", "openrouter") preserves nested path

Evidence

Test Files  1 passed (1)
     Tests  8 passed (8)
  Duration  131ms

git diff --stat upstream/main...HEAD: 3 files changed, 18 insertions(+)

What I Did NOT Verify

• Not verified: end-to-end in running Control UI with a real multi-provider gateway (tested via unit tests only)
• Not verified: edge case where a model alias intentionally contains / but is not provider-qualified (no such case exists in the current codebase — createChatModelOverride already treats / as the qualified signal)

Failure Recovery

If this breaks in production:

• Detection: Model picker shows wrong model or fails to match selected model
• Rollback: Revert the single guard clause in resolveServerChatModelValue
• Blast radius: Only affects model selection display/matching — no server-side impact

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 [email protected]

Changed files

• ui/src/ui/chat-model-ref.test.ts (modified, +33/-0)
• ui/src/ui/chat-model-ref.ts (modified, +16/-1)
• vitest.config.ts (modified, +1/-0)

PR #53220: fix(ui): resolve model provider from catalog instead of stale session default

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/53220

Description (problem / solution / changelog)

lobster-biscuit

Closes #53031 Also fixes #52173, #52482, #51306, #51334, #51139, #51608, #50585, #51809, #51824

Problem

When switching models in the Control UI, the model picker sends the wrong provider prefix. For example, selecting DeepSeek from a session running on ZAI produces zai/deepseek-chat instead of deepseek/deepseek-chat — causing "model not allowed" errors.

This is the root cause behind 9+ independent bug reports across different provider combinations (ZAI/DeepSeek, Ollama/Moonshot, MiniMax/Kimi, etc.).

Root cause

Three call sites use resolveServerChatModelValue(model, modelProvider) which blindly prepends the session's current provider to the bare model name:

1. ui/src/ui/app-render.helpers.ts:542 — active session model display
2. ui/src/ui/app-render.helpers.ts:549 — default model display
3. ui/src/ui/chat/slash-command-executor.ts:158 — /model slash command

The modelProvider from the server reflects the previous model's provider, not the newly selected model's provider.

User impact

Every user who switches between models from different providers in the Control UI gets "model not allowed" errors. Affects all multi-provider setups.

Fix

For bare model names (no /), create a raw ChatModelOverride and resolve the correct provider through normalizeChatModelOverrideValue(), which looks up the model in the catalog and returns the catalog's provider. Falls back to server-provided provider only if catalog lookup fails.

All 3 call sites are fixed. 2 files, +30/-7.

How to verify

1. Configure 2+ providers (e.g. ZAI + DeepSeek)
2. Start a session with one provider's model
3. Switch to another provider's model via UI dropdown
4. Before: "model not allowed". After: switches correctly.

Tests

chat-model-ref.test.ts covers normalizeChatModelOverrideValue catalog lookup. The fix routes through this existing tested path. No new test needed — the functions are correct, only the call sites were wrong.

🤖 Generated with Claude Code

Changed files

• ui/src/ui/app-render.helpers.ts (modified, +23/-2)
• ui/src/ui/chat/slash-command-executor.ts (modified, +7/-5)