PR #74242: fix(bonjour): cap advertiser restarts in a sliding window (#74209)

• Repository: openclaw/openclaw
• Author: Sanjays2402
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74242

Description (problem / solution / changelog)

Fixes one of the concrete bug shapes in #74209: an indefinite bonjour: watchdog detected non-announced service; attempting re-advertise / bonjour: restarting advertiser log loop that the existing safety net was supposed to catch.

The bug

extensions/bonjour/src/advertiser.ts already has a "disable after MAX_CONSECUTIVE_RESTARTS failed restarts" cap. But the watchdog resets consecutiveRestarts = 0 on every tick where any service is observed in the "announced" state:

if (stateUnknown === "announced") {
  consecutiveRestarts = 0;
}

A flapping advertiser — e.g. a duplicate-name conflict on the LAN, or any environment where the service briefly announces and then slides back into probing — cycles between probing and announced and never accumulates 4 consecutive restarts. So the cap never fires and the watchdog churns indefinitely, exactly matching the journal excerpt in #74209 (~1.5 hours of repeating restart/re-advertise log lines).

This also keeps holding cycle state and console-log/exec patches that the disable path is supposed to clean up, which is meaningful on constrained Linux hosts during gateway startup.

The fix

Add a sliding-window absolute cap that is immune to transient announced flips:

const RESTART_WINDOW_MS = 30 * 60_000;
const MAX_RESTARTS_IN_WINDOW = 5;

The watchdog now records each restart timestamp, drops entries outside the window, and disables bonjour the moment either cap (consecutive or windowed) is exceeded. The disable log distinguishes the two reasons and still points at discovery.mdns.mode="off" / OPENCLAW_DISABLE_BONJOUR=1.

The original consecutive-restart path is preserved unchanged for healthy networks where restarts pile up without any announced reset.

Scope

This is intentionally narrow. The broader policy debate in #74209 about default-on bundled plugins and Bonjour startup activation needs maintainer judgment (per the codex review on the issue) and is out of scope for this PR.

Test

A regression test in advertiser.test.ts drives the announced ↔ probing flap through the watchdog with fake timers and asserts:

• The new disable log ("restarts within N minutes") fires.
• After disable, no further advertise() / createService() calls happen.

Verified that the test fails on main (the watchdog churns forever) and passes with the fix. All 44 bonjour tests still green:

✓ extensions/bonjour/src/advertiser.test.ts (26 tests)
✓ extensions/bonjour/src/ciao.test.ts (14 tests)
✓ extensions/bonjour/src/errors.test.ts (4 tests)

Refs #74209.

Changed files

• extensions/bonjour/src/advertiser.test.ts (modified, +59/-0)
• extensions/bonjour/src/advertiser.ts (modified, +27/-2)

PR #74778: fix(bonjour): avoid probing watchdog repair loops

• Repository: openclaw/openclaw
• Author: fuller-stack-dev
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74778

Description (problem / solution / changelog)

Summary

• treat ciao probing as an in-progress state so the Bonjour watchdog stops calling advertise() again while the service is still negotiating
• reset the unhealthy window and add a conflict-settle grace period after name-change and hostname-change events so ciao can resolve duplicate names before OpenClaw tries to recycle the advertiser
• add targeted advertiser regressions for probing and name-conflict loops, plus docs for the new watchdog behavior

Testing

• pnpm exec oxfmt --check --threads=1 CHANGELOG.md docs/gateway/bonjour.md extensions/bonjour/src/advertiser.ts extensions/bonjour/src/advertiser.test.ts
• pnpm test extensions/bonjour/src/advertiser.test.ts
• pnpm build
• pnpm check:changed

Changed files

• docs/gateway/bonjour.md (modified, +5/-0)
• extensions/bonjour/src/advertiser.test.ts (modified, +77/-13)
• extensions/bonjour/src/advertiser.ts (modified, +29/-4)

PR #74811: fix(bonjour): auto-disable mDNS in WSL2 environments

• Repository: openclaw/openclaw
• Author: DhtIsCoding
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74811

Description (problem / solution / changelog)

Problem

In WSL2, the Bonjour/mDNS advertiser repeatedly fails because WSL2's virtualized network stack isolates the Linux guest from the host's multicast domain. This causes @homebridge/ciao to get stuck in the unannounced state and eventually exhaust its restart limit, producing warnings like:

bonjour: disabling advertiser after 3 failed restarts (service stuck in unannounced ...)
set discovery.mdns.mode=\"off\" or OPENCLAW_DISABLE_BONJOUR=1 to disable mDNS discovery

This is a common issue in WSL2 environments where multicast traffic cannot reach the Windows host network.

Solution

Automatically skip Bonjour advertisement when running in WSL2, using the existing isWSL2Sync() utility from plugin-sdk/runtime-env. This mirrors the existing behavior for container environments.

Users can still explicitly opt-in via OPENCLAW_DISABLE_BONJOUR=0 if they have a working multicast bridge setup.

Changes

• extensions/bonjour/src/advertiser.ts: Added WSL2 detection to isDisabledByEnv()
• extensions/bonjour/src/advertiser.test.ts:
  • Added tests for auto-disable and explicit opt-in in WSL2
  • Mocked isWSL2Sync so tests pass consistently regardless of host environment
  • Cleared WSL env vars in enableAdvertiserUnitMode() for test isolation
• CHANGELOG.md: Added entry under Unreleased/Fixes

Testing

• All 28 bonjour advertiser tests pass
• New WSL2 auto-disable test verifies createService is not called
• New WSL2 opt-in test verifies OPENCLAW_DISABLE_BONJOUR=0 overrides detection
• Existing container tests still pass
• Code formatting verified with oxfmt

Related

Refs #74209 (Bonjour can block gateway startup after 2026.4.26 upgrade)

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/bonjour/src/advertiser.test.ts (modified, +50/-0)
• extensions/bonjour/src/advertiser.ts (modified, +4/-1)

PR #74820: fix(bonjour): auto-disable mDNS in WSL2 environments

• Repository: openclaw/openclaw
• Author: DhtIsCoding
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74820

Description (problem / solution / changelog)

Problem

In WSL2, the Bonjour/mDNS advertiser repeatedly fails because WSL2's virtualized network stack isolates the Linux guest from the host's multicast domain. This causes @homebridge/ciao to get stuck in the unannounced state and eventually exhaust its restart limit, producing warnings like:

bonjour: disabling advertiser after 3 failed restarts (service stuck in unannounced ...)
set discovery.mdns.mode=\"off\" or OPENCLAW_DISABLE_BONJOUR=1 to disable mDNS discovery

While c39ca49 (merged) and #74778 (pending) address the symptoms by limiting restart loops, they do not prevent the unnecessary churn in environments where multicast is fundamentally unsupported.

Solution

Automatically skip Bonjour advertisement when running in WSL2, using the existing isWSL2Sync() utility from plugin-sdk/runtime-env. This mirrors the existing behavior for container environments and avoids wasting resources on doomed advertisement attempts.

Users can still explicitly opt-in via OPENCLAW_DISABLE_BONJOUR=0 if they have a working multicast bridge setup.

How This Complements Existing Fixes

• c39ca49: Caps restart loops (symptom mitigation) — still valuable for other constrained environments
• #74778: Fixes probing state handling (bug fix) — orthogonal to this change
• This PR: Prevents WSL2 from entering the failure path entirely (environment-aware optimization)

Changes

• extensions/bonjour/src/advertiser.ts: Added WSL2 detection to isDisabledByEnv()
• extensions/bonjour/src/advertiser.test.ts:
  • Added tests for auto-disable and explicit opt-in in WSL2
  • Mocked isWSL2Sync so tests pass consistently regardless of host environment
  • Cleared WSL env vars in enableAdvertiserUnitMode() for test isolation

Testing

• All 28 bonjour advertiser tests pass
• New WSL2 auto-disable test verifies createService is not called
• New WSL2 opt-in test verifies OPENCLAW_DISABLE_BONJOUR=0 overrides detection
• Existing container tests still pass
• Code formatting verified with oxfmt

Related

Refs #74209

Changed files

• docs/gateway/bonjour.md (modified, +5/-2)
• docs/gateway/discovery.md (modified, +2/-2)
• extensions/bonjour/src/advertiser.test.ts (modified, +50/-0)
• extensions/bonjour/src/advertiser.ts (modified, +4/-1)