TL;DR

Update the check_dingtalk_requirements() function to also check for credentials in PlatformConfig.extra to align with DingTalkAdapter's credential sources.

Guidance

• Review the check_dingtalk_requirements() function in gateway/platforms/dingtalk.py to understand its current implementation and how it only checks environment variables.
• Modify check_dingtalk_requirements() to also check for client_id and client_secret in PlatformConfig.extra, similar to how DingTalkAdapter initializes.
• Consider moving the validation into the adapter construction or connection phase to handle config-driven credentials consistently, as suggested in the issue.
• Verify the fix by running the minimal reproduction code provided and checking that check_dingtalk_requirements() returns True when credentials are present in PlatformConfig.extra.

Example

def check_dingtalk_requirements(config):
    # Check environment variables
    env_vars_set = 'DINGTALK_CLIENT_ID' in os.environ and 'DINGTALK_CLIENT_SECRET' in os.environ
    
    # Check config.extra for credentials
    config_vars_set = 'client_id' in config.extra and 'client_secret' in config.extra
    
    return env_vars_set or config_vars_set

Notes

This solution assumes that the check_dingtalk_requirements() function is the primary blocker for using config-driven credentials. If there are other parts of the code that also need updating, additional changes may be necessary.

Recommendation

Apply the workaround by updating the check_dingtalk_requirements() function to check both environment variables and PlatformConfig.extra for credentials, as this directly addresses the inconsistency between the requirement check and the adapter's initialization.