PR #17715: fix(gateway): apply Discord channel policy to slash commands

• Repository: NousResearch/hermes-agent
• Author: natamox
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/17715

Description (problem / solution / changelog)

What does this PR do?

Applies Discord channel allow/ignore policy checks to native slash command interactions before dispatching them to the gateway session handler. This prevents a bot whose DISCORD_ALLOWED_CHANNELS excludes a channel or thread parent from still executing native slash commands there.

The change also routes normal Discord messages through the same helper so message and slash command channel policy behavior stays aligned. DM slash interactions keep the same allowlist exemption as DM messages.

The /thread native slash command is covered too, since it creates Discord-side state directly instead of going through _run_simple_slash().

Related Issue

Fixes #17724

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✅ Tests (adding or improving test coverage)

Changes Made

• gateway/platforms/discord.py: add shared Discord channel policy helpers and reject blocked native slash commands before deferring or dispatching.
• gateway/platforms/discord.py: apply the same policy to /thread, which bypasses _run_simple_slash().
• tests/gateway/test_discord_slash_commands.py: add regression coverage for native slash commands in allowed, non-allowed, ignored-channel, DM, and /thread contexts.

How to Test

1. Configure a Discord bot with DISCORD_ALLOWED_CHANNELS set to one parent channel.
2. Invoke one of its native slash commands, such as /reset, from a thread whose parent channel is not allowlisted.
3. Confirm the command is rejected ephemerally and does not dispatch to handle_message.

Targeted Discord tests passed locally:

venv/bin/python -m pytest tests/gateway/test_discord_slash_commands.py tests/gateway/test_discord_allowed_channels.py tests/gateway/test_discord_channel_controls.py tests/gateway/test_discord_free_response.py tests/gateway/test_discord_reply_mode.py -q

Result: 115 passed in 4.20s

Full suite was also run locally against this branch and against current origin/main for comparison:

venv/bin/python -m pytest tests/ -q --tb=short --junitxml=/tmp/hermes-pr-full.xml

Branch result: 120 failed, 17813 passed, 48 skipped, 226 warnings in 193.31s

Baseline origin/main result with the same command/environment: 131 failed, 17797 passed, 48 skipped, 225 warnings in 243.22s

The full suite is not currently clean on origin/main; the targeted Discord channel-policy regression tests pass.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes
• I've tested on my platform: Linux

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — N/A
• I've updated cli-config.yaml.example if I added/changed config keys — N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — N/A
• I've considered cross-platform impact — N/A, Discord gateway logic only
• I've updated tool descriptions/schemas if I changed tool behavior — N/A

Screenshots / Logs

115 passed in 4.20s

Branch full suite:
120 failed, 17813 passed, 48 skipped, 226 warnings in 193.31s

origin/main full suite baseline:
131 failed, 17797 passed, 48 skipped, 225 warnings in 243.22s

Changed files

• gateway/platforms/discord.py (modified, +79/-17)
• tests/gateway/test_discord_slash_commands.py (modified, +112/-1)