PR #63453: fix(discord): resolve allowFrom from top-level config for owner and DM auth

• Repository: openclaw/openclaw
• Author: lawrence3699
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/63453

Description (problem / solution / changelog)

Problem

When openclaw doctor --fix or config normalization runs, it promotes channels.discord.dm.allowFrom to the canonical top-level channels.discord.allowFrom and removes the nested copy. Two Discord adapter call sites still only read from account.config.dm?.allowFrom, which is now empty after normalization:

1. Owner authorization (shared.ts → discordConfigAdapter.resolveAllowFrom): senderIsOwner resolves as false for allowlisted DM senders, hiding owner-only tools (cron, gateway).
2. DM security policy (channel.ts → resolveDiscordDmPolicy): the allowlist is invisible to the pairing/allowlist policy resolver.

Observed in the field — the sender is chat-authorized but not owner-authorized:

{ "ownerList": [], "senderIsOwner": false, "isAuthorizedSender": true }

Fix

Both call sites now read account.config.allowFrom ?? account.config.dm?.allowFrom, matching the pattern already used at channel.ts:452 (resolveDmAllowFrom).

Tests

Five unit tests covering:

• Top-level allowFrom (post-normalization) is picked up
• Top-level is preferred when both fields are present
• Fallback to dm.allowFrom when top-level is absent (legacy configs)
• Returns undefined when neither is set
• Empty allowFrom: [] does not fall through to dm.allowFrom

Closes #63261

Changed files

• extensions/discord/src/channel.ts (modified, +1/-1)
• extensions/discord/src/shared.allowfrom.test.ts (added, +55/-0)
• extensions/discord/src/shared.ts (modified, +2/-1)

PR #63515: fix: use top-level allowFrom for Discord owner auth resolution

• Repository: openclaw/openclaw
• Author: EronFan
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/63515

Description (problem / solution / changelog)

Fix: Discord owner auth bypasses channels.discord.allowFrom whitelist

Bug

When Discord owner authentication is used, it bypasses the channels.discord.allowFrom whitelist. In discordConfigAdapter.resolveAllowFrom, only account.config.dm?.allowFrom was checked. When a user configures channels.discord.allowFrom at the top level (not under dm.), owner auth resolution ignores it, causing senderIsOwner=false and hiding owner-only tools like cron and gateway.

Fix

Changed resolveAllowFrom to check account.config.allowFrom first, falling back to account.config.dm?.allowFrom:

// Before (buggy):
resolveAllowFrom: (account: ResolvedDiscordAccount) => account.config.dm?.allowFrom,

// After (fixed):
resolveAllowFrom: (account: ResolvedDiscordAccount) =>
  account.config.allowFrom ?? account.config.dm?.allowFrom,

Impact

• Before: Users allowlisted via top-level channels.discord.allowFrom but not under dm.allowFrom were chat-authorized but NOT owner-authorized
• After: Owner auth correctly resolves from top-level allowFrom, restoring access to owner-only tools (cron, gateway, etc.)

Fixes #63261

Changed files

• extensions/discord/src/shared.ts (modified, +2/-1)
• src/agents/pi-tools.ts (modified, +5/-1)
• src/agents/tool-policy.test.ts (modified, +24/-0)
• src/agents/tool-policy.ts (modified, +19/-2)