PR #84227: fix(config): dedupe missing official plugin warnings

• Repository: openclaw/openclaw
• Author: giodl73-repo
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/84227

Description (problem / solution / changelog)

Summary

• Deduplicate repeated official external plugin install-hint warnings by normalized plugin id.
• Keep the first actionable config path, while preserving generic stale-plugin warnings, removed-plugin warnings, blocked-plugin warnings, and memory-slot-specific wording.
• Add regression coverage for yuanbao appearing in both plugins.entries and plugins.allow.

Fixes #84192.

Verification

• node scripts/run-vitest.mjs src/config/config.plugin-validation.test.ts -t "deduplicates|official external memory slot"
• node scripts/run-vitest.mjs src/config/plugin-auto-enable.channels.test.ts
• node node_modules/@typescript/native-preview/bin/tsgo.js --noEmit --pretty false -p tsconfig.json
• git diff --check -- src/config/validation.ts src/config/config.plugin-validation.test.ts
• /mnt/c/src/claws-hapi/.agents/skills/autoreview/scripts/autoreview --parallel-tests "node scripts/run-vitest.mjs src/config/config.plugin-validation.test.ts -t \"deduplicates|official external memory slot\" && node scripts/run-vitest.mjs src/config/plugin-auto-enable.channels.test.ts"

Note: node scripts/run-vitest.mjs src/config/config.plugin-validation.test.ts currently fails in this WSL/Node 24 worktree on six fixture-loader cases unrelated to this patch (does not auto-allow config-loaded overrides..., plugin config diagnostics, voice-call schema diagnostics, and plugin heartbeat targets). The changed regression subset and adjacent plugin auto-enable file pass.

Real behavior proof

Behavior addressed: A missing official external plugin referenced in both plugins.entries.<id> and plugins.allow now emits one install-hint warning instead of duplicate warnings for the same missing plugin id. Real environment tested: WSL-local OpenClaw source checkout on PR head 2e69db0a. Exact steps or command run after this patch: Created a temporary openclaw.json containing both plugins.entries.yuanbao.enabled=true and plugins.allow=["yuanbao"], then ran OPENCLAW_HOME=<tmp>/home OPENCLAW_STATE_DIR=<tmp>/state OPENCLAW_CONFIG_PATH=<tmp>/state/openclaw.json node --import tsx src/entry.ts doctor --non-interactive --yes --no-workspace-suggestions. Evidence after fix: The real doctor config preflight emitted one missing-plugin install hint for yuanbao:

head: 2e69db0a
config: plugins.entries.yuanbao + plugins.allow[0]=yuanbao
yuanbao_install_warning_count: 1
warning_line: │  - plugins.entries.yuanbao: plugin not installed: yuanbao — install the  │

Observed result after fix: The runtime doctor path reported only the first actionable warning path, plugins.entries.yuanbao, for the duplicated yuanbao config surfaces. It did not emit a second generic install-hint warning for plugins.allow. What was not tested: A live Windows/Bun startup using the reporter's exact default config path; this proof exercises the same runtime doctor config preflight path that reports config warnings before doctor repairs run.

Changed files

• src/config/config.plugin-validation.test.ts (modified, +30/-3)
• src/config/validation.ts (modified, +9/-1)