PR #60852: fix(skills): unify runtime inclusion and available_skills exposure policy

• Repository: openclaw/openclaw
• Author: KimGLee
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/60852

Description (problem / solution / changelog)

Summary

Closes #60716.

This fixes a semantic split in the skills pipeline where a skill could remain runtime-eligible/configured but disappear from the session <available_skills> prompt due to a later formatter-layer filter.

Before this change:

• runtime inclusion was decided via shouldIncludeSkill() in src/agents/skills/config.ts
• prompt visibility was re-decided later in two places:
  • resolveWorkspaceSkillPromptState() in src/agents/skills/workspace.ts
  • formatSkillsForPrompt() in src/agents/skills/skill-contract.ts

That layering allowed one concrete inconsistent state:

• shouldIncludeSkill(...) === true
• but the skill was still omitted from <available_skills> because disable-model-invocation was applied again later while building/rendering the prompt

Root cause

The problem came from prompt visibility being controlled in a different layer than runtime inclusion.

More specifically:

• src/agents/skills/config.ts decided whether a skill was included from the runtime/config/eligibility perspective
• src/agents/skills/workspace.ts then removed entry.invocation?.disableModelInvocation === true entries before prompt generation
• src/agents/skills/skill-contract.ts also treated formatter input as visibility-policy input instead of pure render input

So the bug was not just "a bad filter" — it was that business visibility policy was split across multiple layers.

What changed

• introduced explicit SkillExposure on SkillEntry
• moved prompt visibility policy upstream into workspace skill resolution
• made prompt formatters render the provided skill set instead of re-applying business policy
• updated tests to validate aligned behavior across runtime inclusion and available_skills generation

Changed files

• src/agents/skills.available-skills-visibility.test.ts (added, +35/-0)
• src/agents/skills.issue-60716-design.test.ts (added, +37/-0)
• src/agents/skills.issue-60716-proof.test.ts (added, +42/-0)
• src/agents/skills.resolveskillspromptforrun.test.ts (modified, +22/-0)
• src/agents/skills/compact-format.test.ts (modified, +19/-6)
• src/agents/skills/skill-contract.ts (modified, +2/-3)
• src/agents/skills/types.ts (modified, +7/-0)
• src/agents/skills/workspace.ts (modified, +20/-7)

PR #60853: fix(skills): rebuild snapshot when skills config version changes

• Repository: openclaw/openclaw
• Author: efe-arv
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/60853

Description (problem / solution / changelog)

Problem

Skills configured or added via the Control UI appear as eligible in the UI (skills.status is called fresh each time) but are missing from available_skills in the session system prompt. The assistant then assumes the skill is unavailable even though it works at runtime.

Reported in #60716.

Root Cause

In agent-command.ts, the condition for rebuilding the skills snapshot was:

const needsSkillsSnapshot = isNewSession || !sessionEntry?.skillsSnapshot;

This misses the case where:

1. A session already exists with a cached skillsSnapshot
2. The user adds/configures a skill (bumping skillsSnapshotVersion on disk)
3. The next turn in the same session still uses the stale snapshot because isNewSession is false and skillsSnapshot is truthy

The version number was computed but never compared against the persisted snapshot's version.

Fix

Add a version-mismatch guard to the rebuild condition:

const needsSkillsSnapshot =
  isNewSession ||
  !sessionEntry?.skillsSnapshot ||
  (skillsSnapshotVersion !== undefined &&
    sessionEntry.skillsSnapshot.version !== skillsSnapshotVersion);

When the config version advances (new skill installed, skill enabled/disabled), the cached snapshot is treated as stale and rebuilt on the next agent turn — without requiring the user to start a /new session.

Fixes #60716

Changed files

• src/agents/agent-command.ts (modified, +5/-1)