PR #81408: fix(discord): migrate legacy channel allow before validation

• Repository: openclaw/openclaw
• Author: hclsys
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/81408

Description (problem / solution / changelog)

Fixes #81400.

Summary

• Migrate legacy channels.discord.guilds.*.channels.*.allow aliases into canonical enabled before config validation.
• Covers both top-level Discord config and channels.discord.accounts.* configs.
• Adds a regression test for bundled-channel validation, where the startup-blocking rejection happened.

Root Cause

OpenClawSchema is permissive for extension channel configs, but bundled-channel JSON-schema validation still checked raw Discord config before the legacy allow -> enabled alias was canonicalized. That made documented/legacy per-channel Discord configs fail with:

channels.discord.guilds.<guild>.channels.<channel>: invalid config: must NOT have additional properties: "allow"

Audits

• Existing helper: Discord doctor already migrates this alias; this patch mirrors that compatibility at validation time so startup validation sees canonical config.
• Shared caller: validateConfigObjectRaw is the raw validation boundary used before materialization; canonicalizing here keeps allow: false safe by preserving it as enabled: false instead of dropping it.
• Rival scan: no open PR linked to #81400 or matching this exact validation failure.

Real behavior proof

• Behavior or issue addressed: Discord startup/config validation rejected legacy per-channel guild config containing channels.discord.guilds.*.channels.*.allow, blocking configs that should migrate to canonical enabled.
• Real environment tested: Local OpenClaw checkout on Linux, Node/tsx through repo pnpm exec, using the real validateConfigObject config validation path with bundled-channel validation enabled by sourceRaw.
• Exact steps or command run after this patch:

pnpm exec tsx -e 'import { validateConfigObject } from "./src/config/validation.ts"; const cfg={channels:{discord:{token:"x",groupPolicy:"allowlist",guilds:{"111111111111111111":{channels:{"222222222222222222":{allow:false,requireMention:false}}}}}}}; const result=validateConfigObject(cfg,{sourceRaw:cfg}); console.log(JSON.stringify({ok: result.ok, issues: result.ok ? [] : result.issues.map((issue)=>({path: issue.path, message: issue.message})), channel: result.ok ? result.config.channels?.discord?.guilds?.["111111111111111111"]?.channels?.["222222222222222222"] : undefined}, null, 2));'

• Evidence after fix: Terminal output from the real validation command:

{
  "ok": true,
  "issues": [],
  "channel": {
    "requireMention": false,
    "enabled": false
  }
}

• Observed result after fix: The legacy allow:false channel entry is accepted by config validation and materialized as enabled:false; no bundled-channel additional properties: "allow" error remains.
• What was not tested: Live Discord gateway login was not exercised because this is a startup config-validation migration and the reproduced failure is before gateway connection.

Tests

• pnpm test src/config/config.schema-regressions.test.ts
• pnpm check:test-types
• pnpm exec oxfmt --check --threads=1 src/config/validation.ts src/config/config.schema-regressions.test.ts
• git diff --check

Changed files

• src/config/config.schema-regressions.test.ts (modified, +51/-0)
• src/config/validation.ts (modified, +95/-6)