PR #14392: fix(agent): omit stream_options for Gemini streaming

• Repository: NousResearch/hermes-agent
• Author: sgaofen
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/14392

Description (problem / solution / changelog)

Fixes #14387

Root cause

Hermes always added OpenAI-specific stream_options={"include_usage": true} to chat-completions streaming calls. The direct Google/Gemini endpoint rejects that keyword, causing streaming requests to fail before a response can be read.

Fix

• Add a small chat-completions capability guard for streaming usage chunks.
• Omit stream_options for Gemini/Google direct endpoints.
• Keep requesting stream_options for OpenAI-compatible aggregators such as OpenRouter so usage accounting behavior is preserved.

Tests

• /Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/run_agent/test_streaming.py::TestStreamingAccumulator::test_google_gemini_endpoint_omits_stream_options tests/run_agent/test_streaming.py::TestStreamingAccumulator::test_openai_compatible_streaming_keeps_stream_options -q --tb=short
• /Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/run_agent/test_streaming.py -q --tb=short
• git diff --check

Changed files

• run_agent.py (modified, +12/-1)
• tests/run_agent/test_streaming.py (modified, +62/-1)

PR #14460: fix(agent): skip stream_options for Gemini — unsupported keyword

• Repository: NousResearch/hermes-agent
• Author: nftpoetrist
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/14460

Description (problem / solution / changelog)

What does this PR do?

`stream_options: {"include_usage": True}` is an OpenAI-specific streaming parameter. Gemini's OpenAI-compatible endpoint rejects it with `TypeError: Completions.create() got an unexpected keyword argument 'stream_options'`, causing a non-retryable abort for all Gemini users.

The fix gates `stream_options` behind a provider + base_url check so it is only sent to endpoints that support it. Two failure paths are covered:

• `provider="gemini"` or `"google-gemini-cli"` — explicit Gemini providers
• `provider=""` + `googleapis.com` base URL — the reported bug scenario where the user sets a Gemini endpoint directly without naming the provider

Non-Gemini providers (OpenAI, OpenRouter, Groq, etc.) are unaffected — usage tracking continues to work normally for them.

Related Issue

Fixes #14387

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 🔒 Security fix
• 📝 Documentation update
• ✅ Tests (adding or improving test coverage)
• ♻️ Refactor (no behavior change)
• 🎯 New skill (bundled or hub)

Changes Made

• `run_agent.py`: add `_skip_stream_options` guard in `_call_chat_completions()`; move `stream_options` to a conditional assignment
• `tests/run_agent/test_14387_gemini_stream_options.py`: 10 tests covering both skip paths, the reported scenario (`provider="" + googleapis URL`), and regression checks for non-Gemini providers

How to Test

1. Reproduce the bug (before fix):

   agent = AIAgent(model="gemini-2.5-flash",
                   base_url="https://generativelanguage.googleapis.com/v1beta",
                   api_key="YOUR_GEMINI_KEY")
   agent.chat("Hello")
   # → TypeError: unexpected keyword argument 'stream_options'

2. Run the new tests:

   pytest tests/run_agent/test_14387_gemini_stream_options.py -v

3. All 10 tests should pass.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — or N/A
• I've updated cli-config.yaml.example if I added/changed config keys — or N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
• I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Changed files

• run_agent.py (modified, +9/-1)
• tests/run_agent/test_14387_gemini_stream_options.py (added, +110/-0)