openclaw - 💡(How to fix) Fix [Bug]: failDelivery error silently swallowed in outbound delivery [3 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

In src/infra/outbound/deliver.ts:1288, when partial delivery fails and failDelivery itself fails, .catch(() => {}) swallows the error with no logging.

Error Message

In src/infra/outbound/deliver.ts:1288, when partial delivery fails and failDelivery itself fails, .catch(() => {}) swallows the error with no logging. Add log.warn in the .catch() to match the ackDelivery error handling pattern at lines 1298-1305 in the same file.

Root Cause

In src/infra/outbound/deliver.ts:1288, when partial delivery fails and failDelivery itself fails, .catch(() => {}) swallows the error with no logging.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Summary

In src/infra/outbound/deliver.ts:1288, when partial delivery fails and failDelivery itself fails, .catch(() => {}) swallows the error with no logging.

Impact

The queue entry's retry count is never incremented. Recovery retries the un-acked entry, potentially duplicating messages. This is inconsistent with ackDelivery (lines 1296-1305) which properly distinguishes queue policies and logs warnings.

Suggested fix

Add log.warn in the .catch() to match the ackDelivery error handling pattern at lines 1298-1305 in the same file.

Found by

Codebase audit (finding F019).

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

openclaw - 💡(How to fix) Fix [Bug]: failDelivery error silently swallowed in outbound delivery [3 pull requests]