hermes - ✅(Solved) Fix Bug: Feishu bot_p2p_chat_entered and message_recalled events cause error log spam [1 pull requests, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
NousResearch/hermes-agent#11587Fetched 2026-04-18 06:00:08
View on GitHub
Comments
0
Participants
1
Timeline
2
Reactions
0
Participants
Timeline (top)
cross-referenced ×1referenced ×1

Error Message

  1. Every time a user opens a P2P chat with the bot, the event arrives and the SDK logs a Processor not found for event type... warning (or error) because the handler exists in registration but the actual callback chain is broken
  2. P2P chat entered: Register a no-op lambda to suppress error spam: lambda data: None # No-op: suppress "processor not found" error log spam

Root Cause

  1. Every time a user opens a P2P chat with the bot, the event arrives and the SDK logs a Processor not found for event type... warning (or error) because the handler exists in registration but the actual callback chain is broken
  2. The im.message.recalled_v1 event was registered but had no handler at all, causing errors on recalled messages

Fix Action

Fix

  1. P2P chat entered: Register a no-op lambda to suppress error spam:
.register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(
    lambda data: None  # No-op: suppress "processor not found" error log spam
)
  1. Message recalled: Add empty handler:
.register_p2_im_message_recalled_v1(lambda data: None)  # No-op for recalled messages

PR fix notes

PR #11739: fix(feishu): add docstrings to event handlers to clarify no-op behavior

Description (problem / solution / changelog)

Summary

Add comprehensive docstrings to and event handlers in the Feishu adapter to clarify their purpose as no-op handlers that suppress SDK error log spam.

Root Cause

The and handlers were registered in the Feishu event dispatcher but lacked documentation explaining they are intentionally no-op handlers. This could lead to confusion about why these handlers don't perform any action.

Fix

Added detailed docstrings to both handlers explaining:

  • Their purpose as no-op handlers
  • That they exist to suppress "processor not found" error log spam from the Feishu SDK
  • The specific events they handle

Test Plan

  • Existing unit tests pass
  • No functional changes - only documentation added

Closes NousResearch/hermes-agent#11587

Changed files

  • gateway/platforms/feishu.py (modified, +10/-0)

Code Example

.register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(
    lambda data: None  # No-op: suppress "processor not found" error log spam
)

---

.register_p2_im_message_recalled_v1(lambda data: None)  # No-op for recalled messages
RAW_BUFFERClick to expand / collapse

Bug Description

Feishu platform adapter registers a handler for bot_p2p_chat_entered events but the handler method _on_p2p_chat_entered was never implemented — it simply did nothing (logger.debug(...) pass). This caused two problems:

  1. Every time a user opens a P2P chat with the bot, the event arrives and the SDK logs a Processor not found for event type... warning (or error) because the handler exists in registration but the actual callback chain is broken
  2. The im.message.recalled_v1 event was registered but had no handler at all, causing errors on recalled messages

Fix

  1. P2P chat entered: Register a no-op lambda to suppress error spam:
.register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(
    lambda data: None  # No-op: suppress "processor not found" error log spam
)
  1. Message recalled: Add empty handler:
.register_p2_im_message_recalled_v1(lambda data: None)  # No-op for recalled messages

Additional Note (Pending Inbound Events)

The local version also removed the _pending_inbound_events queue mechanism that was designed to handle events arriving before the adapter loop was ready. This is a separate design decision — worth upstream considering whether the queue was actually needed or whether the simplified approach (drop events if loop not ready) is sufficient.

extent analysis

TL;DR

Register no-op handlers for bot_p2p_chat_entered and im.message.recalled_v1 events to suppress error logs.

Guidance

  • Register a no-op lambda for bot_p2p_chat_entered events using .register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(lambda data: None) to prevent "processor not found" error logs.
  • Add an empty handler for im.message.recalled_v1 events using .register_p2_im_message_recalled_v1(lambda data: None) to handle recalled messages without errors.
  • Review the removal of the _pending_inbound_events queue mechanism to ensure it does not cause issues with event handling.
  • Verify that these changes resolve the error logs and recalled message issues.

Example

# Register no-op handlers for events
.register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(lambda data: None)
.register_p2_im_message_recalled_v1(lambda data: None)

Notes

The provided fix assumes that the no-op handlers are sufficient to resolve the issues. However, the removal of the _pending_inbound_events queue mechanism may require further review to ensure it does not cause problems with event handling.

Recommendation

Apply workaround: Registering no-op handlers for the specified events should resolve the immediate issues, but it is recommended to review the event handling design to ensure it meets the requirements of the application.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - ✅(Solved) Fix Bug: Feishu bot_p2p_chat_entered and message_recalled events cause error log spam [1 pull requests, 1 participants]