hermes - ✅(Solved) Fix [Bug]: Flash Attention optional-skill links to missing reference docs [2 pull requests, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
NousResearch/hermes-agent#14563Fetched 2026-04-24 06:16:30
View on GitHub
Comments
0
Participants
1
Timeline
5
Reactions
0
Author
Participants
Timeline (top)
labeled ×3cross-referenced ×2

Error Message

Additional Logs / Traceback (optional)

Root Cause

Root Cause Analysis (optional)

Documentation/reference drift in the Flash Attention optional skill:

  • Referencing file: optional-skills/mlops/flash-attention/SKILL.md
  • Missing targets:
    • optional-skills/mlops/flash-attention/references/algorithm.md
    • optional-skills/mlops/flash-attention/references/advanced-features.md

Fix Action

Fixed

PR fix notes

PR #14567: docs: remove dead links in flash-attention optional skill

Description (problem / solution / changelog)

Summary

  • remove two dead reference links from optional-skills/mlops/flash-attention/SKILL.md
    • references/algorithm.md
    • references/advanced-features.md
  • keep existing valid references (benchmarks.md, transformers-integration.md) unchanged

Why

Issue #14563 reported that SKILL.md linked to files that do not exist in optional-skills/mlops/flash-attention/references/, which creates broken documentation flow.

Validation

  • verified referenced files in SKILL.md now resolve to existing files only
  • no code/runtime changes (docs-only)

Closes #14563

Changed files

  • optional-skills/mlops/flash-attention/SKILL.md (modified, +0/-4)

PR #14573: Fix/flash attention missing reference docs

Description (problem / solution / changelog)

Resolves #14563

SKILL.md linked to two reference files that did not exist:

  • references/algorithm.md (tiling, recomputation, IO complexity)
  • references/advanced-features.md (RoPE, ALiBi, paged KV cache, custom masks)

Added both files with complete technical content matching the descriptions in SKILL.md and the style of existing reference docs."

Changed files

  • gateway/run.py (modified, +35/-6)
  • optional-skills/mlops/flash-attention/references/advanced-features.md (added, +384/-0)
  • optional-skills/mlops/flash-attention/references/algorithm.md (added, +239/-0)
  • tests/gateway/test_run_progress_topics.py (modified, +246/-0)
RAW_BUFFERClick to expand / collapse

Bug Description

The Flash Attention optional-skill documentation links to two reference files that are not present.

In optional-skills/mlops/flash-attention/SKILL.md, these links are listed:

  • [references/algorithm.md](references/algorithm.md)
  • [references/advanced-features.md](references/advanced-features.md)

But both target files are missing from optional-skills/mlops/flash-attention/references/.

This creates dead links in the skill documentation flow.

Steps to Reproduce

  1. Open optional-skills/mlops/flash-attention/SKILL.md.
  2. Locate the references to references/algorithm.md and references/advanced-features.md (near the end of the file).
  3. List files in optional-skills/mlops/flash-attention/references/.
  4. Observe only benchmarks.md and transformers-integration.md exist.
  5. Confirm algorithm.md and advanced-features.md are missing.

Expected Behavior

All linked reference files in the skill should exist, or links should be removed/updated.

Actual Behavior

SKILL.md links to two reference files that do not exist.

Affected Component

  • Skills (skill loading, skill hub, skill guard)
  • Other (optional-skill documentation references)

Messaging Platform (if gateway-related)

  • N/A (CLI only)

Debug Report

N/A — static documentation/reference consistency issue.

Operating System

N/A (repository content issue)

Python Version

N/A

Hermes Version

N/A

Additional Logs / Traceback (optional)

None.

Root Cause Analysis (optional)

Documentation/reference drift in the Flash Attention optional skill:

  • Referencing file: optional-skills/mlops/flash-attention/SKILL.md
  • Missing targets:
    • optional-skills/mlops/flash-attention/references/algorithm.md
    • optional-skills/mlops/flash-attention/references/advanced-features.md

Proposed Fix (optional)

Maintainer choice:

  1. Add the missing reference files, or
  2. Remove/update the broken links in SKILL.md.

Are you willing to submit a PR for this?

Yes — happy to submit a focused docs PR after maintainer preference is clear.

extent analysis

TL;DR

The most likely fix is to either add the missing reference files algorithm.md and advanced-features.md to the references directory or remove/update the broken links in SKILL.md.

Guidance

  • Verify the existence of the missing files in the repository and check if they are supposed to be part of the documentation.
  • Check the commit history to see if the files were accidentally deleted or renamed.
  • If the files are not intended to be part of the documentation, remove the links from SKILL.md to prevent dead links.
  • If the files are necessary, create them in the references directory with the required content.

Example

No code snippet is necessary for this issue, as it is a documentation consistency problem.

Notes

The fix depends on the maintainer's preference and the intended documentation structure. It is essential to ensure that the documentation is accurate and up-to-date to prevent confusion.

Recommendation

Apply workaround: Remove the broken links from SKILL.md if the missing files are not intended to be part of the documentation, as this is a quick and safe solution to prevent dead links.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING