PR #15481: fix(gateway): pass session messages to shutdown_memory_provider (#15165)

• Repository: NousResearch/hermes-agent
• Author: briandevans
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/15481

Description (problem / solution / changelog)

Summary

• Fixes #15165 Part A — _cleanup_agent_resources previously invoked agent.shutdown_memory_provider() with no arguments, so every memory provider's on_session_end hook received an empty list. Providers with an early-return guard on empty input (Holographic, Hindsight, etc.) never extracted facts from the conversation.
• Forward agent._session_messages — the transcript AIAgent maintains and refreshes every turn via _persist_session — so providers see the actual conversation instead of [].
• Falls back to the legacy no-arg call whenever _session_messages is absent or not a list (test stubs built via object.__new__ or MagicMock) to keep every existing suite green.

The bug

Per #15165:

...any provider that tries to extract facts from the session's conversation gets an empty list. Providers like Holographic (on_session_end([])) have an early return guard... Every gateway restart wipes the session's conversational memory...

Users saw "抱歉，找不到相關的對話記錄" (roughly: "sorry, cannot find the corresponding conversation record") on the first turn after any gateway restart / idle expiry / session reset because no facts had ever been persisted.

The fix

AIAgent.shutdown_memory_provider already accepts messages: list = None (run_agent.py:4126), so this is a pure caller-side change in gateway/run.py:

session_messages = getattr(agent, "_session_messages", None)
if isinstance(session_messages, list):
    agent.shutdown_memory_provider(session_messages)
else:
    agent.shutdown_memory_provider()

• _session_messages is set on AIAgent.__init__ (run_agent.py:1518) and refreshed at the end of every run_conversation turn (_persist_session, line 3264). By the time _cleanup_agent_resources fires, it holds the real transcript.
• isinstance(..., list) discrimination is deliberate — it protects against MagicMock agents (whose attribute access auto-synthesises a child mock, not None) falling through and passing a bogus object to the provider's List[Dict] hook.
• The try/except Exception: pass wrap is inherited; providers that raise never prevent close() from running.
• Paths using skip_memory=True temporary agents (pre-reset memory flush, session hygiene auto-compress, /compress) are no-ops inside shutdown_memory_provider because self._memory_manager is None — so this change has no behaviour effect on them.

Scope

Part A only. Part B of #15165 (adding on_session_end to the Hindsight plugin) is a separate concern that benefits from this fix landing first — without Part A, a Hindsight on_session_end hook would still receive [].

Test plan

• New regression suite: tests/gateway/test_shutdown_memory_provider_messages.py — 7 cases:
  • Populated _session_messages list is forwarded byte-for-byte
  • Empty list is still explicitly forwarded (matches pre-fix observable behaviour)
  • Agent without _session_messages falls back to no-arg call (stub compatibility)
  • MagicMock agent (non-list attribute) falls back to no-arg call
  • Provider exception is swallowed — close() still runs afterward
  • None agent is a no-op (idle-sweep race tolerance)
  • Agent without shutdown_memory_provider method still gets close()
• Regression guard verified: reverted the fix → test_populated_messages_forwarded fails with Expected: mock([...]) / Actual: mock(); restored the fix → all 7 pass.
• Full tests/gateway/ suite: 3703 passed, 9 pre-existing failures (dingtalk, matrix with missing mautrix, one approve-deny test — all fail identically on main, unrelated to this change).
• Related suites pass clean (100/100): test_agent_cache.py, test_compress_command.py, test_background_command.py, test_flush_memory_stale_guard.py, test_session_boundary_hooks.py, test_compress_plugin_engine.py, test_clean_shutdown_marker.py.

Related

• Fixes #15165 (Part A)
• #7759 (closed) — /new / /reset memory commit, different code path
• #14981 — on_session_finalize not fired on idle timeout (orthogonal)
• #15073 — Hindsight sync races interpreter shutdown (orthogonal)

🤖 Generated with Claude Code

Changed files

• gateway/run.py (modified, +15/-1)
• tests/gateway/test_shutdown_memory_provider_messages.py (added, +148/-0)