PR #66225: fix(agents): align final tag regexes to handle self-closing <final/> variant

• Repository: openclaw/openclaw
• Author: suboss87
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/66225

Description (problem / solution / changelog)

Summary

• Aligns FINAL_TAG_SCAN_RE (streaming subscriber) and FINAL_TAG_RE (user-facing text sanitizer) with the broader pattern already used by reasoning-tags.ts
• The narrower regex /<\s*\/?\s*final\s*>/gi matched <final> and </final> but not <final/> (self-closing), which some Gemini models emit
• The shared reasoning-tags.ts already used /<\s*\/?\s*final\b[^<>]*>/gi which handles all variants — this change aligns the other two callsites

Root Cause

Three separate FINAL_TAG_RE regexes existed in the codebase with different patterns:

1. reasoning-tags.ts: \b[^<>]* after final — handles <final/> ✓
2. sanitize-user-facing-text.ts: \s* after final — misses <final/> ✗
3. pi-embedded-subscribe.ts: \s* after final — misses <final/> ✗

The webui streaming path uses #3, so <final/> tags leaked into the display.

Test Plan

• Added regression test for sanitizeUserFacingText stripping <final/> self-closing tags
• Added regression test for streaming subscriber stripping <final/> tags when enforcement is off
• All 82 sanitizer tests pass, all 6 subscriber tests pass, all 45 reasoning-tags tests pass

Closes #65867

Changed files

• src/agents/pi-embedded-helpers.sanitizeuserfacingtext.test.ts (modified, +6/-0)
• src/agents/pi-embedded-helpers/sanitize-user-facing-text.ts (modified, +1/-1)
• src/agents/pi-embedded-subscribe.subscribe-embedded-pi-session.filters-final-suppresses-output-without-start-tag.test.ts (modified, +35/-0)
• src/agents/pi-embedded-subscribe.ts (modified, +11/-3)