hermes - 💡(How to fix) Fix Bug: `_generate_summary` returns None when max_retries=0, injected as conversation content [2 pull requests]

def _generate_summary(self, content: str, metrics: TrajectoryMetrics) -> str:
    prompt = f"..."
    
    for attempt in range(self.config.max_retries):   # range(0) = empty
        try:
            ...
            return self._normalize_summary(raw)
        except Exception:
            ...
    # ← No return statement here — implicit return None

---

summary = self._generate_summary(content_to_summarize, metrics)  # None

compressed.append({
    "from": "human",
    "value": summary    # None injected as message content
})

---

# Simulate the behavior
def _generate_summary(max_retries):
    for attempt in range(max_retries):
        return "summary text"
    # implicit return None

result = _generate_summary(0)
print(result)       # None
print(len(result))  # TypeError: object of type 'NoneType' has no len()

---

def _generate_summary(self, content: str, metrics: TrajectoryMetrics) -> str:
    prompt = f"..."
    
    for attempt in range(self.config.max_retries):
        try:
            ...
            return self._normalize_summary(raw)
        except Exception:
            ...
    
    # Fallback when all retries exhausted or max_retries=0
    logger.warning("Summary generation failed after %d attempts; using placeholder", self.config.max_retries)
    return self._normalize_summary(None)