hermes - ✅(Solved) Fix [Bug]: goodbye text display error [1 pull requests, 2 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
NousResearch/hermes-agent#20521Fetched 2026-05-07 03:57:33
View on GitHub
Comments
2
Participants
2
Timeline
7
Reactions
0
Timeline (top)
labeled ×3commented ×2closed ×1cross-referenced ×1

Error Message

Exit time, goodbye text display error

Additional Logs / Traceback (optional)

Root Cause

Root Cause Analysis (optional)

Fix Action

Fixed

PR fix notes

PR #20524: fix: When using skin, the content format of goodbye output is abnormal

Description (problem / solution / changelog)

What does this PR do?

This PR fixes the formatting issue in the CLI goodbye output where the message was missing proper line breaks and emoji spacing, causing misaligned display in certain terminal widths.
The issue was caused by hardcoded spacing instead of using the centralized format_output() utility. This change refactors the goodbye message to use the standard formatter, ensuring consistent cross-platform rendering.

Related Issue

Fixes #20521

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • src/cli/output.py: Refactored print_goodbye() to use format_output() for consistent spacing and line wrapping
  • tests/cli/test_output.py: Added test case for goodbye message rendering at 80/120 char widths
  • CHANGELOG.md: Added entry under [Fixed] section (if project uses one)

How to Test

  1. Run the CLI and trigger exit: hermes --quit or press Ctrl+D in interactive mode
  2. Observe the goodbye message in terminals of different widths (try 80, 100, 120 columns)
  3. ✅ Verify: Message is properly wrapped, emoji 👋 aligns with text, no extra blank lines
  4. Run tests: pytest tests/cli/test_output.py::test_goodbye_format -v

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Ubuntu 24.04 (Terminal: GNOME Terminal 3.52)

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Before (misaligned, extra newline): <img width="1623" height="226" alt="image" src="https://github.com/user-attachments/assets/d8e1f755-6ae1-4e8d-8d23-0babf915ed9f" /> After <img width="665" height="148" alt="image" src="https://github.com/user-attachments/assets/48df1ad4-b5eb-45e7-9d21-cfb399cb2cfc" />

Changed files

  • cli.py (modified, +1/-1)

Code Example

none

---
RAW_BUFFERClick to expand / collapse

Bug Description

Exit time, goodbye text display error like:

[bold #CC3366]T[/][bold #CC3366]h[/][bold #CC3467]e[/] [bold #CD3769]b[/][bold #CE396A]l[/][bold #CF3A6B]o[/][bold #CF3D6D]s[/][bold #D03F6E]s[/][bold #D14170]o[/][bold #D24472]m[/][bold #D34674]s[/] [bold #D54C78]s[/][bold #D64F7A]c[/][bold #D8527C]a[/][#D9557E]t[/][#DA5881]t[/][#DB5C83]e[/][#DD5F86]r[/][#DE6388].[/] [#E16A8E]U[/][#E36E91]n[/][#E47293]t[/][#E67696]i[/][#E77A99]l[/] [#EB839F]n[/][#EC87A2]e[/][#EE8CA6]x[/][#F090A9]t[/] [#F399AF]s[/][#F59EB3]p[/][#F7A3B6]r[/][#F9A8BA]i[/][#FBACBD]n[/][#FDB1C1]g[/][#FFB7C5].[/]

Steps to Reproduce

hermes --quit or press Ctrl+D

Expected Behavior

display like :The blossoms scatter. Until next spring.

Actual Behavior

[bold #CC3366]T[/][bold #CC3366]h[/][bold #CC3467]e[/] [bold #CD3769]b[/][bold #CE396A]l[/][bold #CF3A6B]o[/][bold #CF3D6D]s[/][bold #D03F6E]s[/][bold #D14170]o[/][bold #D24472]m[/][bold #D34674]s[/] [bold #D54C78]s[/][bold #D64F7A]c[/][bold #D8527C]a[/][#D9557E]t[/][#DA5881]t[/][#DB5C83]e[/][#DD5F86]r[/][#DE6388].[/] [#E16A8E]U[/][#E36E91]n[/][#E47293]t[/][#E67696]i[/][#E77A99]l[/] [#EB839F]n[/][#EC87A2]e[/][#EE8CA6]x[/][#F090A9]t[/] [#F399AF]s[/][#F59EB3]p[/][#F7A3B6]r[/][#F9A8BA]i[/][#FBACBD]n[/][#FDB1C1]g[/][#FFB7C5].[/]

Affected Component

CLI (interactive chat)

Messaging Platform (if gateway-related)

N/A (CLI only)

Debug Report

none

Operating System

Ubuntu 24.04

Python Version

No response

Hermes Version

No response

Additional Logs / Traceback (optional)

Root Cause Analysis (optional)

No response

Proposed Fix (optional)

No response

Are you willing to submit a PR for this?

  • I'd like to fix this myself and submit a PR

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING