PR #25110: fix(memory): verify dependencies are importable before configuring memory provider

• Repository: NousResearch/hermes-agent
• Author: liuhao1024
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25110

Description (problem / solution / changelog)

Summary

hermes memory setup previously configured providers (e.g. Mem0) without verifying that their pip dependencies were actually importable. If uv pip install failed silently (network issues, permission errors, missing uv), the wizard reported success but the plugin crashed at runtime with ModuleNotFoundError.

Root cause

_install_dependencies() in hermes_cli/memory_setup.py always returned None regardless of whether installation succeeded or failed. Both cmd_setup() and cmd_setup_provider() called it but never checked the result — the wizard continued unconditionally.

Fix

Changed _install_dependencies() to return a bool:

• True when all dependencies are importable (already installed or successfully installed)
• False when any dependency is still missing after the install attempt

Both cmd_setup() and cmd_setup_provider() now check this return value and abort with a clear error message if dependencies are still missing:

⚠ Cannot configure 'mem0' — required dependencies are missing.
Install manually and re-run: hermes memory setup

Code Intelligence

• Analyzed: _install_dependencies (callers: 2, callees: 1, flows: 1)
• Blast radius: LOW — both callers (cmd_setup, cmd_setup_provider) are in the same file
• Related patterns: find_provider_dir in plugins/memory/__init__.py (read-only dependency)

Regression coverage

9 new tests in tests/hermes_cli/test_memory_setup_dependency_check.py:

• TestInstallDependenciesReturn (6 tests): True for no plugin dir, no yaml, no deps, all importable; False for missing uv, failed install
• TestCmdSetupAbortOnMissingDeps (3 tests): abort on failed install, abort on missing deps for provider-specific setup, proceed when deps OK

All 18 tests pass (9 new + 9 existing test_memory_reset.py).

Testing

python -m pytest tests/hermes_cli/test_memory_setup_dependency_check.py tests/hermes_cli/test_memory_reset.py -v
# 18 passed

Fixes [Bug]: hermes memory setup does not verify mem0ai is importable before configuring Mem0 #25086

Changed files

• hermes_cli/memory_setup.py (modified, +35/-10)
• tests/hermes_cli/test_memory_setup_dependency_check.py (added, +160/-0)

PR #25117: fix(cli): abort memory setup when provider deps are not importable

• Repository: NousResearch/hermes-agent
• Author: zccyman
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25117

Description (problem / solution / changelog)

Summary

• _install_dependencies() now returns bool — True when all provider dependencies are importable (already present or successfully installed), False when installation fails or is impossible (e.g. uv not found)
• Both callers (cmd_setup, cmd_setup_provider) check the return value and abort early with a clear error message instead of silently proceeding to write config that will fail at runtime with ModuleNotFoundError

Before

$ hermes memory setup → select mem0 → enter API key → ✓ success!
$ hermes chat → use memory → 💥 ModuleNotFoundError: No module named 'mem0'

After

$ hermes memory setup → select mem0 → try install mem0ai → ⚠ install failed
  ⚠ Setup aborted — required dependencies for 'mem0' are not importable.
  Install them manually and re-run this command.

No config is written until dependencies are confirmed importable.

Testing

• 9 new unit tests covering all return paths of _install_dependencies():
  • True: no plugin dir, no plugin.yaml, no pip_deps, already importable, successful install
  • False: uv not found, install failure (CalledProcessError)
• 2 integration tests for cmd_setup_provider abort behavior
• 740 existing tests passing (0 regressions)

Files changed

Closes #25086

Changed files

• hermes_cli/memory_setup.py (modified, +25/-10)
• tests/cli/test_memory_setup_deps.py (added, +152/-0)