PR #13322: fix(honcho): normalize cwd when matching manual session overrides

• Repository: NousResearch/hermes-agent
• Author: Sanjays2402
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/13322

Description (problem / solution / changelog)

Summary

Closes #13284.

HonchoClientConfig.resolve_session_name() does:

manual = self.sessions.get(cwd)

…which is a raw dict lookup on whatever string the caller passed in. When Hermes is launched from different shells the same project directory can be spelled multiple equivalent ways — with/without a trailing slash, as ~/proj vs /home/user/proj, with a . or .. segment — and all but one miss the override, so Hermes silently falls through to the basename-derived session name and effectively starts a fresh Honcho session every time.

The fix

Add a small _match_session_override() helper that tries the existing fast-path dict lookup first (so configs with already-normalized keys keep their exact behaviour) and then falls back to comparing the absolute, ~-expanded, normalized form of both the lookup cwd and each override key.

def _match_session_override(self, cwd: str) -> str | None:
    if not self.sessions:
        return None
    direct = self.sessions.get(cwd)           # fast path
    if direct:
        return direct
    target = self._normalize_cwd(cwd)
    for key, value in self.sessions.items():
        if self._normalize_cwd(key) == target:
            return value
    return None

Normalization uses pathlib.Path.resolve(strict=False), so it doesn't require the directory to actually exist on disk — which matters for test fixtures and remote-cwd callers. A defensive fallback to os.path.normpath(os.path.expanduser(...)) covers pathological inputs.

Regression tests

Added in tests/honcho_plugin/test_client.py::TestResolveSessionName:

Kept the existing test_manual_override unchanged so the fast-path behaviour is still locked in.

Diff

• 2 files changed, +74 / −2.
• plugins/memory/honcho/client.py: +43 / −2 (the helper pair + wire-up).
• tests/honcho_plugin/test_client.py: +33 (regression tests only).

Verification

• python3 -m py_compile plugins/memory/honcho/client.py tests/honcho_plugin/test_client.py → clean.
• The fast-path dict lookup is tried before normalization, so there's zero cost for callers whose override keys already match exactly.
• Normalization never calls the filesystem's stat() — it's string/path-manipulation only — so it's safe for cwd values that don't exist locally (remote task cwds, etc.).

Linked Issue

• Closes #13284

Changed files

• plugins/memory/honcho/client.py (modified, +41/-2)
• tests/honcho_plugin/test_client.py (modified, +33/-0)

PR #13333: fix(honcho): normalize session override paths

• Repository: NousResearch/hermes-agent
• Author: sgaofen
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/13333

Description (problem / solution / changelog)

Fixes #13284.

Root cause: Honcho session overrides checked the configured sessions map only with the raw cwd string. Equivalent directory spellings such as trailing slashes, relative paths, or symlinked paths missed the manual override and fell back to basename-derived sessions.

Fix summary:

• Preserve exact sessions key lookup first so intentionally exact entries still win.
• Add a normalized fallback lookup using Path(...).expanduser().resolve(strict=False) for both the requested cwd and configured session keys.
• Add regression coverage for trailing slash, relative cwd, symlink cwd, and exact-key precedence.

Tests:

• uv run --frozen --python 3.11 --extra dev pytest -o addopts= tests/honcho_plugin/test_client.py -q
• git diff --check -- plugins/memory/honcho/client.py tests/honcho_plugin/test_client.py

Changed files

• plugins/memory/honcho/client.py (modified, +16/-0)
• tests/honcho_plugin/test_client.py (modified, +38/-0)