PR #60874: fix: add additionalProperties:false to tool schemas for OpenAI/Copilot providers

• Repository: openclaw/openclaw
• Author: lml2468
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/60874

Description (problem / solution / changelog)

Summary

Built-in tool schemas (notably read) were missing additionalProperties: false, which OpenAI and GitHub Copilot providers require. This caused HTTP 400 on every agent turn for users with tools.profile: "coding" and OpenAI/Copilot models.

Error: HTTP 400: Invalid schema for function 'read': In context=(), 'additionalProperties' is required to be supplied and to be false.

Root Cause

The upstream pi-coding-agent package emits tool schemas (e.g. for read) without additionalProperties: false. The OpenAI and GitHub Copilot APIs require this field to be explicitly set to false on all function/tool object schemas.

Changes

src/agents/pi-tools.schema.ts

• Added isOpenAIFamilyProvider detection (covers openai, openai-codex, github-copilot)
• Added enforceAdditionalPropertiesFalse() helper that injects additionalProperties: false when targeting OpenAI-family providers
• Hooked into applyProviderCleaning() so all schema paths (simple object schemas AND flattened union schemas) get the injection
• For union/anyOf schemas: use false directly instead of defaulting to true when targeting OpenAI-family providers

src/agents/pi-tools.schema.test.ts

• Added tests for openai provider (should inject additionalProperties: false)
• Added tests for github-copilot provider (should inject additionalProperties: false)
• Added tests for anthropic provider (should NOT inject — Anthropic is fine without it)

Approach

Option B (blanket fix in the schema normalization pass) — normalizeToolParameterSchema is the single point where all tool schemas are normalized before dispatch to providers, making it the right place for this fix. No tool-by-tool changes needed.

Fixes openclaw/openclaw#60821

Changed files

• src/agents/pi-tools.schema.test.ts (modified, +51/-0)
• src/agents/pi-tools.schema.ts (modified, +27/-2)

PR #60939: fix(msteams): replace deprecated HttpPlugin with httpServerAdapter

• Repository: openclaw/openclaw
• Author: coolramukaka-sys
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/60939

Description (problem / solution / changelog)

Summary

• Migrate from the deprecated plugins: [noOpHttpPlugin] pattern to the SDK's public httpServerAdapter option in createMSTeamsApp()
• Eliminates the [DEPRECATED] HttpPlugin in plugins array warning that fires every ~60s in the gateway error log
• Removes ~40 lines of fragile code that used reflect-metadata hacks against internal SDK decorator paths

What changed

extensions/msteams/src/sdk.ts

• Replaced the createNoOpHttpPlugin() function (~40 lines of reflect-metadata decorator hacks) with a 3-line createNoOpHttpServerAdapter() that implements IHttpServerAdapter
• createMSTeamsApp() now passes httpServerAdapter instead of plugins: [noOpHttp]
• Added type-only import for IHttpServerAdapter (dist subpath required — tsgo can't resolve the public barrel re-export chain)
• Fixed stale JSDoc referencing removed HttpPlugin

extensions/msteams/src/sdk.test.ts

• Updated test comment to reflect the new approach

Before / After

Before (main, unpatched) — HttpPlugin warning fires every ~60s (full log):

Apr 04 17:39:47 [WARN] @teams/app [DEPRECATED] HttpPlugin in plugins array will be deprecated...
Apr 04 17:40:47 [WARN] @teams/app [DEPRECATED] HttpPlugin in plugins array will be deprecated...
Apr 04 17:41:47 [WARN] @teams/app [DEPRECATED] HttpPlugin in plugins array will be deprecated...

After (this PR) — zero warnings over 2+ minute observation (full log):

Apr 04 17:42:49 [gateway] ready (6 plugins, 1.9s)
Apr 04 17:42:53 [msteams] starting provider (port 3979)
Apr 04 17:42:55 [msteams] users resolved: 11f44b5b...
(no HttpPlugin warnings)

Teams UI — bot receives messages, streams responses, shows AI label and feedback buttons:

Testing

• All 7 existing msteams SDK tests pass
• Deployed to Azure VM (riley-inbestments.westus2.cloudapp.azure.com) — before/after log comparison
• msteams channel starts, users resolve, messages flow end-to-end
• Verified in Teams via Playwright automation
• Zero HttpPlugin deprecation warnings after sustained activity
• Local gateway verified on macOS

Smoke test results (test plan)

All evidence: SidU/ocmaintenance/teams/testing/screenshots/2026-04-04/

Known issues (pre-existing, not caused by this PR)

• openclaw/openclaw#60821: OpenAI strict mode rejects tool schemas missing additionalProperties: false and required arrays. This affects all tools (read, exec, cron) on main — not introduced by this change.

Fixes: https://github.com/openclaw/openclaw/issues/60732 See also: https://github.com/openclaw/openclaw/issues/55161

🤖 Generated with Claude Code

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/msteams/src/sdk.test.ts (modified, +2/-3)
• extensions/msteams/src/sdk.ts (modified, +16/-60)