PR #20750: fix(core): preserve doc_id in legacy_json_to_doc

• Repository: run-llama/llama_index
• Author: gautamvarmadatla
• State: closed | merged: True
• Link: https://github.com/run-llama/llama_index/pull/20750

Description (problem / solution / changelog)

Description

This PR fixes a legacy deserialization bug in legacy_json_to_doc where the persisted doc_id from legacy payloads was not preserved and a new UUID was generated instead.

Fixes #20749

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

• Yes
• No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

• Yes
• No

Type of Change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

• I added new unit tests to cover this change
• I believe this change is already covered by existing unit tests

Suggested Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added Google Colab support for the newly added notebooks.
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I ran uv run make format; uv run make lint to appease the lint gods

Changed files

• llama-index-core/llama_index/core/storage/docstore/utils.py (modified, +4/-4)
• llama-index-core/tests/storage/docstore/test_legacy_json_to_doc.py (added, +41/-0)

PR #20754: fix: preserve doc_id in legacy_json_to_doc

• Repository: run-llama/llama_index
• Author: danielalanbates
• State: closed | merged: False
• Link: https://github.com/run-llama/llama_index/pull/20754

Description (problem / solution / changelog)

Description

Fixes #20749

legacy_json_to_doc was passing id=id_ to the node constructors, but the Pydantic field is named id_, not id. This caused the persisted doc_id to be silently dropped and a new UUID to be generated, breaking backward compatibility for users restoring or migrating persisted docstores.

Changes

Changed id=id_ to id_=id_ in all four constructor calls within legacy_json_to_doc (Document, TextNode, ImageNode, IndexNode).

Reproduction

from llama_index.core.constants import DATA_KEY, TYPE_KEY
from llama_index.core.schema import Document
from llama_index.core.storage.docstore.utils import legacy_json_to_doc

doc_dict = {
    TYPE_KEY: Document.get_type(),
    DATA_KEY: {
        "text": "hello",
        "extra_info": {},
        "doc_id": "doc-123",
        "relationships": {},
    },
}

loaded = legacy_json_to_doc(doc_dict)
assert loaded.id_ == "doc-123"  # Previously failed: got a new UUID

This PR was created with the assistance of Claude Opus 4.6 by Anthropic. Happy to make any adjustments! Reviewed and submitted by a human.

Changed files

• llama-index-core/llama_index/core/storage/docstore/utils.py (modified, +4/-4)