PR #66321: fix: macOS app stays on 'Health check pending' even when gateway is healthy

• Repository: openclaw/openclaw
• Author: xinmotlanthua
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/66321

Description (problem / solution / changelog)

Summary

• Problem: macOS app shows "Health check pending" even when the gateway is healthy, because summaryLine requires resolveLinkChannel to be non-nil — which fails when no channel has linking info
• Why it matters: Users see a permanent "pending" state even with a fully functional gateway, causing confusion and false alarm
• What changed: When resolveLinkChannel returns nil, state and summaryLine now fall back to snapshot.ok — returning .ok / "Gateway healthy" when the gateway is responsive, and .unknown / "Health check pending" only when snapshot.ok is not true
• What did NOT change (scope boundary): No changes to health check networking, gateway probing, or channel linking logic

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #66306
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: summaryLine and state properties require resolveLinkChannel to return a non-nil channel to show healthy status, but gateways without linked channels (fresh installs, single-channel setups) never satisfy this condition
• Missing detection / guardrail: No test case for health status with snapshot.ok = true but no linked channel
• Contributing context (if known): Link channel requirement was likely added for multi-channel setups but breaks single/no-channel configurations

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
• Target test or file: HealthStoreStateTests.swift
• Scenario the test should lock in: Gateway healthy (ok=true) with no linked channel should show healthy status
• Why this is the smallest reliable guardrail: Direct test of the state resolution logic
• If no new test is added, why not: N/A — three new tests added

User-visible / Behavior Changes

• macOS app now correctly shows healthy status when gateway is responsive, regardless of channel linking state

Diagram (if applicable)

Before:
[gateway ok=true, no link channel] -> state: .unknown -> "Health check pending"

After:
[gateway ok=true, no link channel] -> state: .ok -> "Gateway healthy"

Security Impact (required)

• New permissions/capabilities? No
• Secrets/tokens handling changed? No
• New/changed network calls? No
• Command/tool execution surface changed? No
• Data access scope changed? No

Repro + Verification

Environment

• OS: macOS
• Runtime/container: macOS app
• Model/provider: N/A
• Integration/channel (if any): N/A

Steps

1. Install macOS app
2. Configure gateway without channel linking
3. Observe "Health check pending" despite healthy gateway

Expected

• Shows "Gateway healthy" or similar positive status

Actual

• Shows "Health check pending" indefinitely

Evidence

• Trace/log snippets: Code path analysis showing state resolution

Human Verification (required)

• Verified scenarios: Traced HealthStore state/summaryLine logic
• Edge cases checked: No snapshot (pending), snapshot ok + no link (now healthy), snapshot ok + link (healthy with channel info), snapshot not ok (error)
• What you did not verify: macOS app UI rendering end-to-end

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? Yes
• Config/env changes? No
• Migration needed? No

Risks and Mitigations

• Risk: Users without linked channels may lose the "link your channel" prompt
  • Mitigation: Only changed the health status display, not the linking UX flow

🤖 AI-assisted (Claude) — macOS health status fix, human-verified

Changed files

• apps/macos/Sources/OpenClaw/HealthStore.swift (modified, +35/-3)
• apps/macos/Tests/OpenClawIPCTests/HealthStoreStateTests.swift (modified, +142/-0)