PR #12564: fix(models): use local catalog for MiniMax validation instead of /v1/models (fixes false negative)

• Repository: NousResearch/hermes-agent
• Author: ygd58
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/12564

Description (problem / solution / changelog)

Problem

MiniMax (both global and CN endpoints) does not implement /v1/models — it returns 404. When a user runs hermes model MiniMax-M2.7, validate_requested_model() calls fetch_api_models() which probes /v1/models, gets 404, returns None, and falls through to the generic error:

Could not reach the MiniMax API to validate 'MiniMax-M2.7'.
If the service isn't down, this model may not be valid.

The chat endpoint works fine — only the models listing endpoint is missing.

Fix

Add a minimax / minimax-cn branch in validate_requested_model() that uses provider_model_ids() (local catalog) instead of probing /v1/models. Same pattern already used for Bedrock.

• Valid model names → accepted=True, recognized=True
• Close matches → auto-correct
• Unknown names → accepted=True with a warning (user may have plan-specific access)

Result

hermes model MiniMax-M2.7 succeeds when MiniMax-M2.7 is in the local catalog. No network call needed for validation.

Fixes #12547

Changed files

• hermes_cli/models.py (modified, +43/-0)

PR #12829: fix(models): validate MiniMax models against static catalog

• Repository: NousResearch/hermes-agent
• Author: Tranquil-Flow
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/12829

Description (problem / solution / changelog)

What changed

Added a catalog-based validation path for MiniMax models in _resolve_model_selection(), mirroring the existing openai-codex pattern. MiniMax does not expose a /models API endpoint, so the previous code would fall through to a generic "Could not reach API" rejection even for valid model names.

Before: Any MiniMax model would be rejected with "Could not reach API" because the API probe to /v1/models always fails for MiniMax.

After: MiniMax models are validated against a static catalog (case-insensitive matching), with:

• Exact match detection for known models
• Auto-correct for close matches (edit distance via difflib.get_close_matches)
• Suggestion display for near-matches
• Graceful acceptance with warning for unrecognized models (since the catalog may be incomplete)

Note: Unlike openai-codex which rejects unknown models (accepted: False), MiniMax accepts unknown models with a warning (accepted: True) because the catalog may not cover all available models and the user's model may still work server-side.

How to test

1. Configure MiniMax as a provider with a valid API key
2. Set model to MiniMax-M2.7 — should be accepted without warning
3. Set model to minimax-m2.7 — should be accepted (case-insensitive)
4. Set model to MiniMax-Text-01 — should auto-correct with suggestion
5. Set model to MiniMax-Unknown — should be accepted with warning
6. Run the test suite:

   pytest tests/test_minimax_model_validation.py -v

Platforms tested

• Linux (Docker container, Python 3.11)

Closes #12611 Closes #12460 Closes #12399 Closes #12547

Changed files

• hermes_cli/models.py (modified, +45/-0)
• tests/test_minimax_model_validation.py (added, +130/-0)

PR #12842: fix(models): validate MiniMax models against static catalog

• Repository: NousResearch/hermes-agent
• Author: teknium1
• State: closed | merged: True
• Link: https://github.com/NousResearch/hermes-agent/pull/12842

Description (problem / solution / changelog)

Salvage of #12829 by @Tranquil-Flow onto current main.

Summary

hermes model MiniMax-M2.7 now succeeds. Previously, validation hard-rejected every MiniMax model because MiniMax's /v1/models endpoint returns 404 and commit aeb53131f flipped probe failure from warn-and-accept to hard-reject.

Changes

• hermes_cli/models.py: new minimax / minimax-cn branch in validate_requested_model(), placed before the live probe — mirrors the existing openai-codex pattern. Case-insensitive exact match, case-insensitive auto-correct at 0.9 cutoff, similar-model suggestions at 0.5, unknown names accepted with a warning (catalog may be incomplete).
• tests/test_minimax_model_validation.py: 7 tests covering exact match, case-insensitivity, near-match suggestion, unknown-model acceptance with warning, and catalog-path-is-taken guard.

Validation

• Targeted pytest: 70/70 passed across tests/test_minimax_model_validation.py + tests/hermes_cli/test_model_validation.py.
• E2E with fetch_api_models stubbed to return None: exact/lowercase/uppercase all accepted+recognized, MinMax-M2.7 auto-corrects to MiniMax-M2.7, unknown models accepted with the "MiniMax does not expose a /models endpoint" warning, minimax-cn behaves the same.

Closes #12611 Closes #12460 Closes #12399 Closes #12547

Supersedes #12564 (duplicate, same root cause, less coverage).

Changed files

• hermes_cli/models.py (modified, +45/-0)
• tests/test_minimax_model_validation.py (added, +130/-0)