PR #25131: fix(agent): persist complete model runtime state on /model switch

• Repository: NousResearch/hermes-agent
• Author: zccyman
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25131

Description (problem / solution / changelog)

Summary

Both gateway /model and CLI /model --global now persist the complete runtime tuple to config.yaml:

model.default
model.provider
model.base_url      # NEW: was missing or conditionally written
model.api_mode      # NEW: was never persisted

Before

Gateway /model (gateway/run.py):

model_cfg["default"] = result.new_model
model_cfg["provider"] = result.target_provider
if result.base_url:                    # ← only writes when truthy
    model_cfg["base_url"] = result.base_url
# api_mode: never persisted

CLI /model --global (cli.py, 2 locations):

save_config_value("model.default", result.new_model)
if result.provider_changed:
    save_config_value("model.provider", result.target_provider)
# base_url: never persisted
# api_mode: never persisted

After

Gateway — unconditional with empty-string clearing:

model_cfg["base_url"] = result.base_url or ""
model_cfg["api_mode"] = result.api_mode or ""

CLI — two additional save_config_value calls:

save_config_value("model.base_url", result.base_url or "")
save_config_value("model.api_mode", result.api_mode or "")

Impact

Fixes the class of bugs where switching models leaves stale endpoint/protocol state:

Testing

• 5 new tests covering all persistence paths
• 29 existing model-switch tests passing (0 regressions)

Files changed

Closes #25107 Closes #25106 See also #25105 (kimi-for-coding alias normalization — separate issue)

Changed files

• cli.py (modified, +6/-0)
• gateway/run.py (modified, +3/-2)
• tests/gateway/test_model_switch_config_persistence.py (added, +209/-0)

PR #25136: fix: canonicalize Kimi provider alias

• Repository: NousResearch/hermes-agent
• Author: mudrii
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25136

Description (problem / solution / changelog)

Bug

Hermes uses kimi-coding / kimi-coding-cn for runtime, auth, and config, but models.dev may identify the endpoint family as kimi-for-coding. Persisting the models.dev alias leaves downstream runtime/config paths with an unknown or wrong provider id.

Fixes #25105

Summary

Canonicalize kimi-for-coding during model switching to the correct Hermes provider id before resolving credentials or persisting config. The fix preserves the China Kimi variant when the user requested kimi-coding-cn / kimi-cn / moonshot-cn.

TDD / ATDD coverage

• Added a focused regression test that reproduces the reported behavior.
• Implemented the minimal production change needed to satisfy the regression.
• Re-ran the targeted test file to guard nearby behavior.

Test plan

• /Users/mudrii/src/hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_model_switch_custom_providers.py -q -o 'addopts=' -> 20 passed

Review notes

• Kept the change scoped to the issue-specific runtime path.
• No secrets are persisted or logged.

Changed files

• hermes_cli/model_switch.py (modified, +11/-0)
• hermes_cli/providers.py (modified, +2/-0)
• tests/hermes_cli/test_model_switch_custom_providers.py (modified, +97/-0)