PR #59759: fix(cli): prevent unconditional model check when skipping auth in agents add

• Repository: openclaw/openclaw
• Author: openperf
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/59759

Description (problem / solution / changelog)

Summary

• Problem: When running openclaw agents add and answering "No" to "Configure model/auth for this agent now?", the CLI crashes with TypeError: Cannot read properties of undefined (reading 'resolveConfigured'). This completely blocks adding new agents without immediate auth configuration. (Issue #59654)
• Root Cause: The warnIfModelConfigLooksOff function was being called unconditionally after the auth prompt, even when wantsAuth === false. This function triggers loadModelCatalog, which loads provider plugins and initializes the plugin registry. Because the new agent's directory and auth state are not fully initialized when auth is skipped, subsequent channel setup logic (setupChannels -> collectChannelStatus) attempts to resolve the status of lazy-loaded channel setup wizards. These wizards fail to initialize their status property correctly in this incomplete state, leading to the TypeError when wizard.status.resolveConfigured is accessed.
• Fix: Moved the warnIfModelConfigLooksOff call inside the if (wantsAuth) block. This ensures the model/auth consistency check only runs when the user actually configures auth, matching the behavior in the main setup.ts wizard. This prevents premature plugin registry initialization and avoids the downstream crash in channel setup.
• What changed:
  • src/commands/agents.commands.add.ts: Moved warnIfModelConfigLooksOff inside the wantsAuth condition.
  • src/commands/agents.add.test.ts: Added a regression test to verify warnIfModelConfigLooksOff is not called when auth setup is skipped.
• What did NOT change (scope boundary): The logic inside warnIfModelConfigLooksOff itself was not changed. The channel setup logic (setupChannels) and plugin loading mechanisms remain untouched. The fix is strictly limited to the control flow of the agents add wizard.

Reproduction

1. Run openclaw agents add test-agent
2. Enter a workspace directory
3. Answer "No" to "Copy auth profiles from main?" (if prompted)
4. Answer "No" to "Configure model/auth for this agent now?"
5. Observe that the wizard continues to channel setup instead of crashing with a TypeError.

Risk / Mitigation

• Risk: The model check warning might be skipped in cases where it would have been useful to warn the user about a missing default model.
• Mitigation: This is the intended behavior when a user explicitly chooses not to configure auth/models at creation time. They can always run openclaw configure later. A regression test was added to agents.add.test.ts to ensure this specific interactive path remains stable and does not trigger the check.

Change Type (select all)

• Bug fix

Scope (select all touched areas)

• CLI

Linked Issue/PR

Fixes #59654

Changed files

• src/commands/agents.add.test.ts (modified, +54/-0)
• src/commands/agents.commands.add.ts (modified, +4/-5)