PR #73654: fix(cli): make crestodian exit non-zero on no-TTY (#73646)

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73654

Description (problem / solution / changelog)

What

Fixes #73646. pnpm openclaw crestodian < /dev/null (and node ./dist/index.js crestodian < /dev/null) currently:

1. Detects no TTY
2. Prints Crestodian needs an interactive TTY. Use --message for one command. to stderr
3. Returns from runCrestodian cleanly — no thrown error, no process.exitCode set
4. The CLI wrapper runCommandWithRuntime only sets runtime.exit(1) in its catch path, so the silent return falls through and Node exits 0

Shell scripts and CI flows reading $? see success and proceed as if Crestodian ran. The two in-tree sibling subcommands for the same condition (models auth login, secrets configure) both throw new Error("…") and exit non-zero. The bare-root crestodian path at cli/run-main.ts:399-404 also already sets process.exitCode = 1 directly. Crestodian-as-subcommand is the lone outlier.

Fix

Replace the silent runtime.error(...) + return in src/crestodian/crestodian.ts:93-96 with a throw new Error(...). The CLI wrapper's catch then runs runtime.error + exit(1) and the process exits non-zero. Behavior matches the bare-root path and the models auth login / secrets configure precedents.

if (!interactive || !inputIsTty || !outputIsTty) {
  throw new Error("Crestodian needs an interactive TTY. Use --message for one command.");
}

Verified locally

npx oxlint src/crestodian/crestodian.ts src/crestodian/crestodian.test.ts
# Found 0 warnings and 0 errors.

npx vitest run src/crestodian/crestodian.test.ts
# Tests  4 passed (4)

The new test pins the regression: runCrestodian({ input: { isTTY: false }, output: { isTTY: false } }) rejects with /needs an interactive TTY/ so the CLI wrapper's catch fires.

Pre-implement audit

1. Existing-helper check. Error message + pattern reused verbatim from sibling subcommands (models auth login, secrets configure); setup-token uses the identical throw new Error("… requires an interactive TTY.") shape. ✅
2. Shared-helper caller check. runCrestodian is called from 4 sites — cli/run-main.ts:423,433, cli/program/register.onboard.ts:182, cli/program/register.crestodian.ts:30 — all wrapped in runCommandWithRuntime (or runCommandWithRuntime-style catch in run-main.ts). All four catch paths surface the thrown error and exit non-zero. ✅
3. Broader-fix rival scan. Zero rival PRs reference #73646. ✅

Note

#73562 (plugins uninstall < /dev/null exits 13) is a separate bug filed by the same reporter — wrong exit code there, but at least non-zero. Not addressed here.

lobster-biscuit: 73646-crestodian-no-tty-exit

Sign-Off:

• I have read and agree to the OpenClaw Contributor License Agreement.

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/crestodian/crestodian.test.ts (modified, +21/-0)
• src/crestodian/crestodian.ts (modified, +6/-2)

PR #73776: fix(cli): make crestodian exit non-zero on no-TTY (#73646)

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73776

Description (problem / solution / changelog)

Fixes #73646.

Re-submitting the closed PR #73654 (auto-closed during overnight queue rotation) with no functional change. crestodian invoked without a TTY now exits non-zero with a clear stderr message instead of the silent zero-exit that broke CI scripts.

What changed

• `src/crestodian/crestodian.ts` — early-return with non-zero exit + stderr line when stdout is not a TTY
• `src/crestodian/crestodian.test.ts` — coverage for the no-TTY path

Test

``` pnpm vitest run src/crestodian/crestodian.test.ts ```

🦞 lobster-biscuit

Sign-Off: hclsys

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/crestodian/crestodian.test.ts (modified, +21/-0)
• src/crestodian/crestodian.ts (modified, +6/-2)

PR #73928: fix(cli): set non-zero exit code when crestodian detects non-TTY [AI-assisted]

• Repository: openclaw/openclaw
• Author: luyao618
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73928

Description (problem / solution / changelog)

🤖 AI-assisted (built with Codex via Hermes orchestration). Test level: fully tested. Prompt summary available on request.

Summary

• Problem: runCrestodian() detects a non-TTY stdin/stdout and prints an error message, but returns without setting process.exitCode. The process exits with code 0, misleading shell scripts and CI flows into thinking Crestodian ran successfully.
• Why it matters: Exit code 0 signals success. Scripts gating on Crestodian's exit code silently proceed despite the error. The two sibling subcommands (models auth login and plugins uninstall) both exit non-zero for the same condition.
• What changed: Added process.exitCode = 1 before the early return in runCrestodian() (consistent with the parallel TTY guard already present in run-main.ts). Added two regression tests covering the stdin-not-TTY and stdout-not-TTY paths.
• What did NOT change (scope boundary): No changes to the interactive TUI path, the one-shot --message path, or the run-main.ts bare-root TTY guard.

Change Type (select all)

• Bug fix

Scope (select all touched areas)

• CLI

Linked Issue/PR

• Closes #73646
• This PR fixes a bug or regression

Root Cause

• Root cause: The runCrestodian() function in src/crestodian/crestodian.ts called runtime.error() and returned early when stdin/stdout was not a TTY, but never set process.exitCode. The parallel guard in src/cli/run-main.ts (line 403) already sets process.exitCode = 1 for the same condition on the bare-root path, but the explicit openclaw crestodian subcommand path was missed.
• Missing detection / guardrail: No test asserted process.exitCode after the non-TTY early return.
• Contributing context: The two code paths (bare root in run-main.ts vs explicit subcommand in crestodian.ts) were likely written at different times, and the exit code was only added to the former.

Regression Test Plan

• Coverage level that should have caught this:
  • Unit test
• Target test or file: src/crestodian/crestodian.test.ts
• Scenario the test should lock in: When runCrestodian() is called with input.isTTY = false or output.isTTY = false, process.exitCode must be set to 1.
• Why this is the smallest reliable guardrail: The TTY check is purely a process-level concern — a unit test asserting process.exitCode after calling runCrestodian() with mock streams covers the exact failure mode without needing integration infrastructure.
• Existing test that already covers this (if any): N/A
• If no new test is added, why not: N/A — two new tests added.

User-visible / Behavior Changes

• openclaw crestodian (and bare openclaw on the explicit subcommand path) now exits with code 1 instead of 0 when stdin or stdout is not a TTY. The error message is unchanged.

Diagram (if applicable)

N/A

Security Impact (required)

• New permissions/capabilities? No
• This fix only changes the process exit code from 0 to 1 in an error path. No security-sensitive behavior is affected.

Changed files

• src/crestodian/crestodian.test.ts (modified, +34/-1)
• src/crestodian/crestodian.ts (modified, +2/-1)

PR #74059: fix(crestodian): exit with code 1 on non-TTY stdin

• Repository: openclaw/openclaw
• Author: Linux2010
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74059

Description (problem / solution / changelog)

Summary

Fixes #73646

The crestodian command now exits with code 1 when stdin is not a TTY, matching sibling commands like models auth login and secrets configure.

Problem

Previously, openclaw crestodian < /dev/null would:

• Print error message: "Crestodian needs an interactive TTY. Use --message for one command."
• Exit with code 0 (success)
• Shell scripts and CI would incorrectly see "success" and proceed

Solution

Added runtime.exit(1); before the return; statement when TTY check fails.

Changes

if (!interactive || !inputIsTty || !outputIsTty) {
    runtime.error("Crestodian needs an interactive TTY. Use --message for one command.");
+   runtime.exit(1);
    return;
}

Test Plan

Added 3 regression tests:

1. stdin not TTY: Simulates piping from /dev/null
2. stdout not TTY: Simulates output redirect
3. interactive flag false: Explicit non-interactive mode

All tests verify:

• exit 1 is thrown
• Error message is printed

Manual Testing

# Before fix
node dist/index.js crestodian < /dev/null
echo $?  # 0 (wrong)

# After fix
node dist/index.js crestodian < /dev/null
echo $?  # 1 (correct)

Workaround

Users can still use --message for one-shot commands:

openclaw crestodian -m "status"

Security

No security implications - purely exit code fix for shell script compatibility.

Changed files

• src/crestodian/crestodian.test.ts (modified, +52/-0)
• src/crestodian/crestodian.ts (modified, +1/-0)