PR #71692: fix(feishu): accept schema 2 card action context

• Repository: openclaw/openclaw
• Author: SnowSky1
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/71692

Description (problem / solution / changelog)

Summary

• Accept context.open_chat_id as the chat fallback for Feishu Schema 2.0 card-action callbacks.
• Fall back to the operator IDs when v2 payloads omit context.open_id / context.user_id, preserving the existing internal event shape.
• Add lifecycle regression coverage for a Schema 2.0 card callback that previously parsed as malformed.

Root Cause parseFeishuCardActionEventPayload only accepted legacy context.chat_id, context.open_id, and context.user_id fields. Schema 2.0 card callbacks provide open_chat_id context instead, so valid button clicks were dropped before dispatch.

Validation

• node scripts/run-vitest.mjs run --config test/vitest/vitest.extension-feishu.config.ts extensions/feishu/src/monitor.lifecycle.test.ts
• pnpm exec oxfmt --check --threads=1 CHANGELOG.md extensions/feishu/src/monitor.account.ts extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts
• pnpm exec oxlint --tsconfig tsconfig.oxlint.extensions.json extensions/feishu/src/monitor.account.ts extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts

Closes #71670

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/feishu/src/monitor.account.ts (modified, +3/-3)
• extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts (modified, +29/-0)

PR #71787: fix(feishu): accept schema 2 card callbacks

• Repository: openclaw/openclaw
• Author: rubencu
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/71787

Description (problem / solution / changelog)

Summary

• Problem: Feishu Schema 2.0 interactive card callbacks could be logged as malformed and dropped before dispatch.
• Why it matters: Quick-action/approval card button clicks would silently do nothing for affected Feishu/Lark installs.
• What changed: Normalize both legacy nested card-action payloads and Schema 2.0 callback shapes, including context.open_chat_id and nested operator.user_id.* identity objects.
• What did NOT change (scope boundary): No outbound card schema, routing, permission, or command semantics changed.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #71670
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: The Feishu card-action parser required the older operator.open_id / context.chat_id style shape, while Schema 2.0 callbacks can provide operator identifiers inside operator.user_id.* and chat context as context.open_chat_id.
• Missing detection / guardrail: Lifecycle coverage did not include a Schema 2.0 callback using the nested operator identity object and open_chat_id context.
• Contributing context (if known): The SDK flattens event envelopes before dispatching to the card.action.trigger handler, so the parser needs to accept both callback payload variants at that boundary.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts
• Scenario the test should lock in: a Schema 2.0 card-action callback with nested operator.user_id.{open_id,user_id,union_id} and context.open_chat_id routes to the reply dispatcher.
• Why this is the smallest reliable guardrail: it exercises the real monitor handler boundary where the malformed callback was dropped.
• Existing test that already covers this (if any): none.
• If no new test is added, why not: N/A.

User-visible / Behavior Changes

Feishu/Lark Schema 2.0 card button clicks that previously no-op'd now dispatch normally.

Diagram (if applicable)

Before:
[Schema 2.0 card click] -> [parser expects legacy fields] -> [malformed/drop]

After:
[Schema 2.0 card click] -> [normalize callback shape] -> [dispatch reply]

Security Impact (required)

• New permissions/capabilities? (Yes/No) No
• Secrets/tokens handling changed? (Yes/No) No
• New/changed network calls? (Yes/No) No
• Command/tool execution surface changed? (Yes/No) No
• Data access scope changed? (Yes/No) No
• If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

• OS: macOS
• Runtime/container: local Node/pnpm worktree
• Model/provider: N/A
• Integration/channel (if any): Feishu/Lark
• Relevant config (redacted): N/A

Steps

1. Register a card.action.trigger payload using Schema 2.0 callback fields with nested operator.user_id.* and context.open_chat_id.
2. Include a valid OpenClaw Feishu card interaction envelope in action.value.
3. Invoke the Feishu monitor card action handler.

Expected

• The callback is accepted and routed to the Feishu reply dispatcher.

Actual

• Before this fix, the callback was rejected as malformed before dispatch.

Evidence

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Local verification:

• pnpm test extensions/feishu/src/monitor.lifecycle.test.ts
• pnpm test extensions/feishu/src/bot.card-action.test.ts
• pnpm check:changed
• codex review --base origin/main (clean after addressing one schema-shape finding)

Human Verification (required)

What you personally verified (not just CI), and how:

• Verified scenarios: targeted Feishu lifecycle/card-action tests and the changed-file validation gate pass locally.
• Edge cases checked: legacy flat operator IDs still work; Schema 2.0 nested operator identity and open_chat_id context now work.
• What you did not verify: live Feishu/Lark button click against a real tenant.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes/No) Yes
• Config/env changes? (Yes/No) No
• Migration needed? (Yes/No) No
• If yes, exact upgrade steps: N/A

Risks and Mitigations

• Risk: Accepting more callback shapes could accidentally weaken malformed payload filtering.
  • Mitigation: The parser still requires a token, operator open ID, action tag, and record-valued action payload before constructing the synthetic event.

Changed files

• extensions/feishu/src/card-action.ts (modified, +15/-9)
• extensions/feishu/src/monitor.account.ts (modified, +38/-24)
• extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts (modified, +50/-0)