PR #73554: fix(cli): reject missing plugin ids before config writes

• Repository: openclaw/openclaw
• Author: ai-hpc
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73554

Description (problem / solution / changelog)

Summary

• Problem: openclaw plugins enable <id> and plugins disable <id> accepted nonexistent plugin ids and could write stale plugins.entries.<id> config.
• Why it matters: A typo could leave persistent junk config and repeated stale-plugin warnings until manual cleanup.
• What changed: Resolve the requested plugin id against the discovered plugin registry before mutating config; missing ids now exit 1 without writing config.
• What did NOT change (scope boundary): This does not change plugin discovery, install/uninstall behavior, Gateway plugin loading, or cleanup of stale entries already written by older versions.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #73551
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: The plugin policy mutation commands used the raw CLI argument directly for config writes before verifying that the id matched a discovered plugin.
• Missing detection / guardrail: Existing policy tests covered successful enable/disable paths, but not nonexistent plugin ids or no-write behavior on failure.
• Contributing context (if known): The stale-plugin warning path can identify missing config entries, but the enable/disable write path did not use registry knowledge as a gate.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/cli/plugins-cli.policy.test.ts
• Scenario the test should lock in: plugins enable missing-plugin and plugins disable missing-plugin exit 1 and do not call config write or registry refresh seams.
• Why this is the smallest reliable guardrail: The bug is in the CLI policy mutation handler, so a focused command test can assert the write seam is not reached.
• Existing test that already covers this (if any): None.
• If no new test is added, why not: N/A

User-visible / Behavior Changes

openclaw plugins enable <missing-id> and openclaw plugins disable <missing-id> now fail with a clear plugin-not-found error and do not mutate openclaw.json.

Diagram (if applicable)

Before:
plugins enable fake-id -> write plugins.entries.fake-id -> stale warning later

After:
plugins enable fake-id -> registry lookup fails -> exit 1, no config write

Security Impact (required)

• New permissions/capabilities? (No)
• Secrets/tokens handling changed? (No)
• New/changed network calls? (No)
• Command/tool execution surface changed? (No)
• Data access scope changed? (No)
• If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

• OS: Ubuntu/Linux
• Runtime/container: Node 22, pnpm dev checkout
• Model/provider: N/A
• Integration/channel (if any): Plugins CLI
• Relevant config (redacted): plugins.entries policy config

Steps

1. Run openclaw plugins enable totally-fake-plugin-xyz.
2. Inspect openclaw.json.
3. Run openclaw plugins disable totally-fake-plugin-xyz.

Expected

• Missing plugin ids fail before config mutation.
• No stale plugins.entries.<id> entry is written.

Actual

• Before this change, the enable path could write plugins.entries.<id> = { enabled: true } and exit 0.
• After this change, missing ids exit 1 and the config write seam is not called.

Evidence

Attach at least one:

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Local verification:

• pnpm test src/cli/plugins-cli.policy.test.ts -- --reporter=verbose
• pnpm test src/cli/plugins-cli.policy.test.ts src/cli/plugins-cli.list.test.ts src/cli/plugins-cli.uninstall.test.ts src/cli/plugins-cli.install.test.ts src/cli/plugins-config.test.ts src/plugins/enable.test.ts -- --reporter=verbose
• pnpm check:changed -- --base upstream/main
• git diff --check

Human Verification (required)

• Verified scenarios: Missing plugin ids for plugins enable and plugins disable reject before config writes; adjacent plugin CLI tests still pass.
• Edge cases checked: Existing successful enable/disable policy paths still pass with discovered plugin ids. The registry snapshot includes disabled plugins, so valid disabled plugins remain enableable.
• What you did not verify: Full packaged CLI invocation against a real user config.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes)
• Config/env changes? (No)
• Migration needed? (No)
• If yes, exact upgrade steps: N/A

Risks and Mitigations

• Risk: Existing stale plugin entries written by older behavior are not automatically removed by this PR.
  • Mitigation: This PR prevents new stale entries through enable/disable; cleanup of already-stale config remains a separate doctor/fix concern.

Changed files

• src/cli/plugins-cli-test-helpers.ts (modified, +29/-0)
• src/cli/plugins-cli.policy.test.ts (modified, +135/-0)
• src/cli/plugins-cli.ts (modified, +37/-6)

PR #73566: fix(cli): handle closed plugin uninstall prompt

• Repository: openclaw/openclaw
• Author: ai-hpc
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73566

Description (problem / solution / changelog)

Summary

• Problem: openclaw plugins uninstall <id> could leave the confirmation prompt await unsettled when stdin closed before an answer, causing Node to exit 13 with Detected unsettled top-level await.
• Why it matters: CI/scripts/detached shells get an internal Node crash instead of a clear CLI error; operators do not learn to use --force for non-interactive uninstall.
• What changed: promptYesNo() now detects readline close/EOF before an answer and throws a typed prompt-closed error; plugins uninstall catches that case and exits 1 with an actionable message.
• What did NOT change (scope boundary): Piped y / n answers and plugins uninstall --force remain supported; this does not change install records, uninstall planning, or plugin deletion semantics.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #73562
• Related #73551
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: promptYesNo() awaited readline.question() without handling readline close / EOF, so closed stdin could leave the top-level CLI await unsettled.
• Missing detection / guardrail: Existing prompt and uninstall tests covered normal answers and --force, but not EOF-before-answer.
• Contributing context (if known): plugins uninstall already supports --force, but the interactive path did not fail cleanly when no confirmation input was possible.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/cli/prompt.test.ts, src/cli/plugins-cli.uninstall.test.ts
• Scenario the test should lock in: readline close before an answer rejects with PromptInputClosedError; plugins uninstall converts that specific prompt failure into exit 1 without config/index/file mutation.
• Why this is the smallest reliable guardrail: The bug is in the prompt helper and uninstall command handler; focused tests cover both the shared primitive and command-level UX.
• Existing test that already covers this (if any): None.
• If no new test is added, why not: N/A

User-visible / Behavior Changes

openclaw plugins uninstall <id> < /dev/null now fails with a clear CLI error instead of surfacing Node's unsettled top-level-await warning. Users can rerun interactively, pipe y/n, or pass --force for non-interactive uninstall.

Diagram (if applicable)

Before:
closed stdin -> readline question never answers -> unsettled top-level await -> Node exit 13

After:
closed stdin -> prompt close detected -> plugins uninstall exits 1 with --force guidance

Security Impact (required)

• New permissions/capabilities? (No)
• Secrets/tokens handling changed? (No)
• New/changed network calls? (No)
• Command/tool execution surface changed? (No)
• Data access scope changed? (No)
• If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

• OS: Ubuntu/Linux
• Runtime/container: Node 22.22.1, pnpm dev checkout
• Model/provider: N/A
• Integration/channel (if any): Plugins CLI
• Relevant config (redacted): A managed plugin entry or install record for the uninstall target

Steps

1. Ensure plugins uninstall <id> targets a managed plugin entry or install record.
2. Run openclaw plugins uninstall <id> < /dev/null without --force.
3. Observe the command result.

Expected

• CLI exits 1 with an actionable confirmation-input error.
• No config, install index, or plugin file mutation occurs.

Actual

• Before this change, the prompt path could surface Node's Detected unsettled top-level await and exit 13.
• After this change, the closed-input case is detected and handled before mutation.

Evidence

Attach at least one:

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Local verification:

• pnpm test src/cli/prompt.test.ts src/cli/plugins-cli.uninstall.test.ts -- --reporter=verbose
• pnpm check:changed -- --base upstream/main
• git diff --check HEAD
• Direct closed-stdin smoke against patched promptYesNo(): returns PromptInputClosedError with process exit 0 in the harness instead of Node exit 13.

Human Verification (required)

• Verified scenarios: Prompt close before answer; uninstall prompt-close command path; existing --force uninstall path; normal prompt default/y/n behavior.
• Edge cases checked: The fix avoids a blanket non-TTY ban, so piped answers remain supported by design.
• What you did not verify: Full packaged pnpm openclaw plugins uninstall <id> < /dev/null against a real installed plugin, because the focused prompt and CLI seams directly cover the root cause.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes)
• Config/env changes? (No)
• Migration needed? (No)
• If yes, exact upgrade steps: N/A

Risks and Mitigations

• Risk: promptYesNo() is shared by a few CLI flows, so changing EOF handling can affect other confirmation prompts.
  • Mitigation: The new behavior only triggers when readline closes before an answer; normal answers, defaults, and global --yes remain covered by existing prompt tests.

Changed files

• src/cli/plugins-cli-test-helpers.ts (modified, +7/-0)
• src/cli/plugins-cli.ts (modified, +20/-2)
• src/cli/plugins-cli.uninstall.test.ts (modified, +52/-0)
• src/cli/prompt.test.ts (modified, +35/-3)
• src/cli/prompt.ts (modified, +35/-2)

PR #73623: fix: validate plugin id before writing config in plugins enable/disable

• Repository: openclaw/openclaw
• Author: 1yihui
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73623

Description (problem / solution / changelog)

Summary

Validate that a plugin id exists in the discovered plugin registry before writing to plugins.entries config. For nonexistent ids, exit non-zero with a clear error message and do not mutate config. Fixes both plugins enable and plugins disable.

Changes

• plugins enable: add pre-write validation gate — reject unknown ids with exit 1
• plugins disable: add same pre-write validation gate for symmetry
• Error message: "Plugin not found: <id>. Run openclaw plugins list to see installed plugins."

Testing

• Unit test: plugins enable with nonexistent id asserts exit code != 0, error message contains plugin name, config not written
• Unit test: plugins disable with nonexistent id asserts same behavior
• Existing plugin enable/disable still works (integration smoke test)

Fixes openclaw/openclaw#73551

Changed files

• src/cli/plugins-cli.enable-disable.test.ts (added, +75/-0)
• src/cli/plugins-cli.ts (modified, +28/-0)

PR #73932: fix(cli): validate plugin ID before enabling

• Repository: openclaw/openclaw
• Author: Linux2010
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73932

Description (problem / solution / changelog)

Summary

Fixes #73551

The plugins enable command now validates the plugin ID against discovered plugins before modifying config.

Problem

Previously, openclaw plugins enable <invalid-id> would silently write invalid plugin entry to config, causing potential gateway startup failures.

Solution

Added validation using buildPluginDiagnosticsReport to check if plugin ID exists before enabling.

Changes

+ const report = buildPluginDiagnosticsReport({ config: cfg });
+ const availableIds = report.plugins.map((p) => p.id);
+ if (!availableIds.includes(id)) {
+   defaultRuntime.log(theme.error(`Plugin "${id}" not found.`));
+   process.exitCode = 1;
+   return;
+ }

Test Plan

1. openclaw plugins enable nonexistent-plugin → Error + exit 1
2. openclaw plugins list shows available plugins
3. openclaw plugins enable telegram → Success

Security

No security implications - purely CLI input validation.

Changed files

• src/cli/plugins-cli.ts (modified, +24/-6)

PR #74016: fix: reject unknown plugin ids in plugins enable/disable

• Repository: openclaw/openclaw
• Author: yfge
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74016

Description (problem / solution / changelog)

Background

openclaw plugins enable <id> and openclaw plugins disable <id> currently mutate plugins.entries.<id> even when the requested plugin was never discovered. That leaves a stale config entry behind, prints a contradictory success message, and exits 0 on typos.

Changes

• validate the requested plugin id against the discovered plugin snapshot before mutating config
• reuse the resolved canonical plugin id for enable/disable logging and slot selection
• return a clear Plugin not found: <id>. Run \openclaw plugins list` to see installed plugins.` error and exit 1 when the plugin is unknown
• add CLI regression coverage that asserts unknown enable/disable requests do not write config or refresh the registry

Validation

• pnpm test src/cli/plugins-cli.policy.test.ts
• pnpm exec oxfmt --check --threads=1 src/cli/plugins-cli.ts src/cli/plugins-cli.policy.test.ts
• OPENCLAW_STATE_DIR=$(mktemp -d) pnpm openclaw plugins enable totally-fake-plugin-xyz → exits 1 and leaves config unchanged

Impact

• typoed or nonexistent plugin ids stop failing open
• operators no longer get stale plugins.entries.* warnings carried into later plugin commands
• shell scripts can reliably branch on a non-zero exit when a requested plugin id does not exist

Fixes #73551.

Changed files

• src/cli/plugins-cli.policy.test.ts (modified, +45/-0)
• src/cli/plugins-cli.ts (modified, +30/-6)