vllm - ✅(Solved) Fix [Bug] Potential incorrect tokenizer source path in RunAI object storage pull [1 pull requests, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
vllm-project/vllm#37836Fetched 2026-04-08 01:17:49
View on GitHub
Comments
0
Participants
1
Timeline
3
Reactions
0
Author
Participants
Timeline (top)
cross-referenced ×1labeled ×1referenced ×1

Fix Action

Fixed

PR fix notes

PR #37867: Fix incorrect tokenizer source path in RunAI object storage pull (#37836)

Description (problem / solution / changelog)

Summary

  • Fix bug in maybe_pull_model_tokenizer_for_runai where the tokenizer branch incorrectly passed model instead of tokenizer to pull_files(), causing tokenizer files to be fetched from the wrong object storage path when model != tokenizer.

Fixes #37836

Test plan

  • Verify that when model != tokenizer and both are RunAI object storage URIs, tokenizer files are pulled from the tokenizer path (not the model path).
  • Existing behavior when model == tokenizer is unchanged (handled by the early return branch above).

🤖 Generated with Claude Code

Changed files

  • vllm/config/model.py (modified, +1/-1)

Code Example

Your output of `python collect_env.py` here
RAW_BUFFERClick to expand / collapse

Your current environment

<details> <summary>The output of <code>python collect_env.py</code></summary>
Your output of `python collect_env.py` here
</details>

🐛 Describe the bug

Hi, thanks for the great work on vLLM!

While reviewing the RunAI object storage integration, I noticed a potential inconsistency in maybe_pull_model_tokenizer_for_runai.

In the tokenizer branch:

object_storage_tokenizer = ObjectStorageModel(url=tokenizer)
object_storage_tokenizer.pull_files(
    model,
    ignore_pattern=[...],
)

Here, model is passed to pull_files() instead of tokenizer.

From the RunAI Model Streamer S3 implementation:

def pull_files(model_path: str, dst: str, ...):
    ...
    bucket_name, base_dir, files = list_files(s3, model_path, ...)
    ...
    s3.download_file(bucket_name, file, destination_file)

The model_path argument is directly used as the object storage source for listing and downloading files.

This suggests that in the tokenizer branch above, files would be pulled from model rather than tokenizer.

This seems inconsistent with the expected behavior where model and tokenizer URIs are handled independently.

When model != tokenizer, this may lead to:

  • tokenizer files being fetched from the model path
  • missing or incorrect tokenizer files
  • silent mismatch between model and tokenizer

This issue is likely masked when model == tokenizer.

The tokenizer branch would likely call:

object_storage_tokenizer.pull_files(tokenizer, ...)

so that files are fetched from the correct object storage path.

Could you confirm whether this is expected behavior or a leftover issue?

Happy to submit a PR if this is unintended.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

extent analysis

Fix Plan

To resolve the inconsistency in maybe_pull_model_tokenizer_for_runai, we need to pass tokenizer instead of model to the pull_files method.

Step-by-Step Solution:

  1. Update the maybe_pull_model_tokenizer_for_runai function:

object_storage_tokenizer = ObjectStorageModel(url=tokenizer) object_storage_tokenizer.pull_files( tokenizer, # Update 'model' to 'tokenizer' ignore_pattern=[...], )

2. **Verify the change** by testing the function with different `model` and `tokenizer` values to ensure files are fetched from the correct object storage path.

### Verification
To verify the fix, you can add test cases to check the following scenarios:
* `model == tokenizer`: Ensure files are fetched correctly.
* `model != tokenizer`: Ensure files are fetched from the `tokenizer` path, not the `model` path.

### Extra Tips
* Make sure to update the documentation and tests accordingly to reflect the change.
* Consider adding a check to ensure `model` and `tokenizer` are not the same to prevent silent mismatches.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING