codex - 💡(How to fix) Fix Bug: Race condition in memory Phase 2 agent status subscription

TL;DR

Subscribing to the status channel before spawning the task may resolve the race condition.

Guidance

• Consider reordering the code to subscribe to the status channel before spawning the task using tokio::spawn, ensuring that the subscription is established before the task begins execution.
• Review the agent_control.subscribe_status method to understand its behavior and guarantees regarding event delivery, as this may inform the choice of synchronization mechanism.
• Investigate alternative synchronization mechanisms, such as using a Mutex or RwLock, to guarantee that no events are missed during the transition.
• Verify that the proposed fix does not introduce new issues, such as deadlocks or performance bottlenecks, by thoroughly testing the modified code.

Example

let rx = agent_control.subscribe_status(thread_id).await;
tokio::spawn(async move {
    // Existing task code
});

Notes

The suggested fix assumes that reordering the subscription and task spawning is feasible and effective. However, the optimal solution may depend on the specific requirements and constraints of the codex-rs system.

Recommendation

Apply workaround: Reorder the subscription and task spawning to ensure that the subscription is established before the task begins execution, as this approach is likely to mitigate the race condition with minimal changes to the existing code.