hermes - 💡(How to fix) Fix Bug: Race condition in OpenAI client replacement can close active connections [2 pull requests]

def _ensure_primary_openai_client(self, *, reason: str) -> Any:
    with self._openai_client_lock():
        client = getattr(self, "client", None)
        if client is not None and not self._is_openai_client_closed(client):
            return client
    # ← Lock released here. Thread B can enter and also see closed client.

    # Both Thread A and Thread B reach here:
    if not self._replace_primary_openai_client(reason=f"recreate_closed:{reason}"):
        raise RuntimeError("Failed to recreate closed OpenAI client")
    with self._openai_client_lock():
        return self.client

---

def _replace_primary_openai_client(self, *, reason: str) -> bool:
    with self._openai_client_lock():
        old_client = getattr(self, "client", None)
        ...
        self.client = new_client
    # ← Lock released, then old client closed:
    self._close_openai_client(old_client, reason=f"replace:{reason}", shared=True)
    return True

---

def _ensure_primary_openai_client(self, *, reason: str) -> Any:
    with self._openai_client_lock():
        client = getattr(self, "client", None)
        if client is not None and not self._is_openai_client_closed(client):
            return client
        # Replace INSIDE the lock:
        old_client = client
        try:
            new_client = self._create_openai_client(self._client_kwargs, reason=reason, shared=True)
        except Exception:
            raise RuntimeError("Failed to recreate closed OpenAI client")
        self.client = new_client
    # Close old client outside lock (safe now — no thread can re-select it)
    if old_client is not None:
        self._close_openai_client(old_client, reason=f"replace:{reason}", shared=True)
    return new_client