PR #60058: fix(pi): use resolvePathArg for read tool path alias in handler

• Repository: openclaw/openclaw
• Author: jwchmodx
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/60058

Description (problem / solution / changelog)

Summary

The diagnostic guard in handleToolExecutionStart for the read tool was manually checking only the path and file_path arg aliases, missing the filePath camelCase alias.

The existing resolvePathArg utility in tool-display-common.ts already handles all three aliases (path, file_path, filePath). This PR replaces the inline alias lookup with a call to resolvePathArg, fixing the missed alias and reducing duplication.

Test plan

• Call read tool with { filePath: "..." } — warning should no longer fire incorrectly
• Existing handler tests pass (30 tests)

Fixes #60008

🤖 Generated with Claude Code

Changed files

• src/agents/pi-embedded-subscribe.handlers.tools.ts (modified, +2/-8)

---

PR #60325: fix: accept read path aliases in diagnostic guard

• Repository: openclaw/openclaw
• Author: QRG-cloud
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/60325

Description (problem / solution / changelog)

Summary

• accept file and filePath aliases in the read-tool diagnostic guard
• keep the existing warning when no supported path alias is present
• add targeted test coverage for all supported read path aliases

Problem

Issue #60008 reports false warnings from the embedded tool diagnostic path:

• read tool called without path

The read tool itself already accepts multiple path aliases via later normalization, but handleToolExecutionStart() only checked path and file_path before logging the warning. When models used file or filePath, the tool could still succeed while the diagnostic layer emitted misleading warnings.

Fix

Narrowly update handleToolExecutionStart() in src/agents/pi-embedded-subscribe.handlers.tools.ts so the read-path diagnostic check recognizes all supported aliases:

• path
• file_path
• file
• filePath

This keeps the warning behavior intact for truly missing paths while removing false positives for valid alias usage.

Tests

Added targeted coverage in src/agents/pi-embedded-subscribe.handlers.tools.test.ts to verify:

• no warning for path
• no warning for file_path
• no warning for file
• no warning for filePath
• warning still occurs when none of the supported aliases are present

Ran:

• corepack pnpm vitest run src/agents/pi-embedded-subscribe.handlers.tools.test.ts -t "handleToolExecutionStart read path checks"

Notes

The broader test file currently contains unrelated failing tests on main, so validation here is intentionally scoped to the read-path diagnostic cases touched by this change.

Changed files

• src/agents/pi-embedded-subscribe.handlers.tools.test.ts (modified, +8/-3)
• src/agents/pi-embedded-subscribe.handlers.tools.ts (modified, +5/-1)

---

PR #68296: fix(agents): add file and filePath aliases to read tool diagnostic path check

• Repository: openclaw/openclaw
• Author: 1aifanatic
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/68296

Description (problem / solution / changelog)

Summary

• The read tool diagnostic guard in handleToolExecutionStart only checked path and file_path when deciding whether to emit a "read tool called without path" warning
• Models like Claude commonly use file and filePath as the parameter name
• This triggered false-positive log warnings even though the tool itself succeeds via normalization in normalizeToolParams()

Change Type

• Bug fix

Scope

• Skills / tool execution

Linked Issue/PR

• Closes #60008

Root Cause

handleToolExecutionStart resolves the read tool path from record.path and record.file_path only. The file and filePath aliases — which Claude models commonly emit — were not checked, causing spurious warnings that can flood logs and cascade into retry loops.

Fix

Extended the ternary chain to also check record.file and record.filePath before falling back to the empty string. Added test cases for both new aliases.

Changed files

• src/agents/pi-embedded-subscribe.handlers.tools.test.ts (modified, +33/-1)
• src/agents/pi-embedded-subscribe.handlers.tools.ts (modified, +5/-1)