PR #75401: fix(mcp): normalize empty parameter-free tool schema before sending to OpenAI (#75362)

• Repository: openclaw/openclaw
• Author: SymbolStar
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/75401

Description (problem / solution / changelog)

Fixes #75362

Summary

MCP servers may return inputSchema as { type: "object" } without a properties field, or with properties set to undefined/null. The hasTopLevelObjectSchema guard only checked "properties" in schemaRecord (key existence) without verifying the value is a real object. This caused such schemas to pass through unnormalized, resulting in OpenAI rejecting them with 400 Invalid schema for function: object schema missing properties.

Root Cause

In pi-tools-parameter-schema.ts:

• hasTopLevelObjectSchema checked "properties" in schemaRecord — which is true even when the value is undefined
• isTypedSchemaMissingProperties checked !("properties" in schemaRecord) — which is false when the key exists with value undefined

Result: schemas like { type: "object", properties: undefined } passed through without normalization.

Fix

• Tighten hasTopLevelObjectSchema to require properties to be a non-null object
• Broaden isTypedSchemaMissingProperties to catch properties keys with undefined/null/non-object values

Regression History

• #60158: original issue report
• #60176: original fix (normalize {} → { type: "object", properties: {} })
• #75362: this regression (edge case with properties: undefined not caught)

Tests

Added unit tests in:

• openai-tool-schema.test.ts: strict mode normalization for empty/undefined properties
• pi-tools.schema.test.ts: normalizeToolParameters with properties: undefined and properties: null

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/agents/openai-tool-schema.test.ts (modified, +20/-0)
• src/agents/pi-tools-parameter-schema.ts (modified, +15/-2)
• src/agents/pi-tools.schema.test.ts (modified, +32/-0)

PR #75941: fix(mcp): normalize empty parameter-free tool schema before sending to OpenAI (#75362)

• Repository: openclaw/openclaw
• Author: clawsweeper[bot]
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/75941

Description (problem / solution / changelog)

Repairs the existing branch for #75401 and fixes #75362. The narrow fix should update the shared tool-parameter schema normalizer so top-level object schemas with properties set to undefined, null, or another non-object value are normalized to { type: "object", properties: {} } before OpenAI tool registration, without rewriting valid properties or top-level allOf/union behavior. Keep focused tests for normalizeToolParameterSchema/normalizeToolParameters and any strict OpenAI compatibility coverage already added by the PR. Add or repair the CHANGELOG.md fix entry with allowed contributor credit for @SymbolStar. Before merge routing, rerun Codex /review and pnpm check:changed.

ClawSweeper 🐠 replacement reef notes:

• Cluster: automerge-openclaw-openclaw-75401
• Source PRs: https://github.com/openclaw/openclaw/pull/75401
• Credit: Preserve #75401 author credit for @SymbolStar in PR body/history and changelog attribution if the changelog entry remains user-facing.; Keep #60176/@Bartok9 as historical regression context; do not remove existing credit from the earlier fix.; Do not add forbidden attribution for @codex, @openclaw, or @steipete.
• Validation: pnpm test src/agents/pi-tools.schema.test.ts src/agents/openai-tool-schema.test.ts; pnpm check:changed
• Repair fallback: To https://github.com/SymbolStar/openclaw.git ! [remote rejected] HEAD -> fix/mcp-empty-schema-75362 (permission denied) error: failed to push some refs to 'https://github.com/SymbolStar/openclaw.git'

fish notes: model gpt-5.5, reasoning high; reviewed against 8c5c0daac8be.

Changed files

• CHANGELOG.md (modified, +1/-1)
• src/agents/openai-tool-schema.test.ts (modified, +23/-0)
• src/agents/pi-tools-parameter-schema.ts (modified, +19/-16)
• src/agents/pi-tools.schema.test.ts (modified, +37/-0)